Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for prefetchCount env var #676

Merged

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented Mar 31, 2022

Changes

  • 🧹 Changed prefetchCount env variable name to Parallelism in both Trigger and Source, to better reflect its functionallity
  • 🧹 Updated tests, samples and docs accordingly

/kind enhancement

Fixes #615

Release Note

🧹 Changed prefetchCount env variable name to Parallelism in both Trigger and Source, to better reflect its functionallity

@knative-prow knative-prow bot added kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 31, 2022
@gabo1208 gabo1208 changed the title Better naming for paralelism Better naming for prefetchCoun env var Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #676 (657815a) into main (a93b956) will increase coverage by 0.25%.
The diff coverage is 66.33%.

@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   75.08%   75.34%   +0.25%     
==========================================
  Files          47       44       -3     
  Lines        2910     2900      -10     
==========================================
  Hits         2185     2185              
+ Misses        585      578       -7     
+ Partials      140      137       -3     
Impacted Files Coverage Δ
pkg/apis/sources/v1alpha1/rabbitmq_defaults.go 0.00% <0.00%> (ø)
pkg/apis/sources/v1alpha1/rabbitmq_types.go 50.00% <ø> (ø)
pkg/rabbit/service.go 0.00% <0.00%> (ø)
pkg/reconciler/trigger/trigger.go 59.40% <44.68%> (-0.83%) ⬇️
pkg/adapter/adapter.go 61.18% <62.50%> (-5.81%) ⬇️
pkg/apis/sources/v1alpha1/rabbitmq_validation.go 61.90% <66.66%> (ø)
pkg/apis/eventing/v1/trigger_validation.go 71.87% <100.00%> (ø)
pkg/rabbitmqnaming/naming.go 100.00% <100.00%> (ø)
pkg/reconciler/broker/broker.go 89.67% <100.00%> (+0.28%) ⬆️
pkg/reconciler/broker/broker_config.go 74.60% <100.00%> (+0.83%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea542...657815a. Read the comment docs.

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunyiLyu, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 84f6a42 into knative-extensions:main Apr 1, 2022
@gabo1208 gabo1208 changed the title Better naming for prefetchCoun env var Better naming for prefetchCount env var Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better naming for parallel worker count
2 participants