Broker and Trigger use delivery spec for dead letter messaging #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
kind/bug
- Plumbs deliverySpec.BackoffDelay through to the dispatcher
gab-satchi
force-pushed
the
dlq-dispatcher
branch
from
6c5aa04
to
dee0a4e
Compare
Codecov Report
@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 75.38% 76.02% +0.63%
==========================================
Files 32 32
Lines 2397 2419 +22
==========================================
+ Hits 1807 1839 +32
+ Misses 523 511 -12
- Partials 67 69 +2
Continue to review full report at Codecov.
|
gabo1208
reviewed
Apr 20, 2022
| @@ -242,6 +242,7 @@ func (r *Reconciler) reconcileDLXDispatcherDeployment(ctx context.Context, b *ev | |||
| Broker: b, | |||
| Image: r.dispatcherImage, | |||
| //ServiceAccountName string | |||
There was a problem hiding this comment.
nit the comment goes in the line below
gabo1208
approved these changes
Apr 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The dispatcher creation for broker and trigger is very similar. Can be consolidated in a follow-up PR
/kind bug
Release Note