Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed source docs #777

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🧹 Updating Eventing RabbitMQ's Source docs to reflect recent changes

/kind documentation

Fixes #763

Release Note

- 🧹 Updating Eventing RabbitMQ's Source docs to reflect recent changes

@knative-prow knative-prow bot added kind/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #777 (851b457) into main (ae9a633) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   75.33%   75.16%   -0.18%     
==========================================
  Files          35       39       +4     
  Lines        2526     2621      +95     
==========================================
+ Hits         1903     1970      +67     
- Misses        559      585      +26     
- Partials       64       66       +2     
Impacted Files Coverage Δ
pkg/apis/eventing/v1/broker_validation.go
pkg/apis/eventing/v1/trigger_validation.go
pkg/apis/eventing/v1alpha1/register.go 0.00% <0.00%> (ø)
pkg/apis/eventing/v1alpha1/rabbitmq_defaults.go 0.00% <0.00%> (ø)
pkg/apis/eventing/v1alpha1/rabbitmq_types.go 100.00% <0.00%> (ø)
pkg/apis/eventing/v1alpha1/trigger_validation.go 71.11% <0.00%> (ø)
pkg/apis/eventing/v1alpha1/broker_validation.go 83.11% <0.00%> (ø)
pkg/apis/eventing/v1alpha1/rabbitmq_validation.go 60.97% <0.00%> (ø)
pkg/reconciler/source/resources/receive_adapter.go 96.34% <0.00%> (+0.23%) ⬆️
pkg/reconciler/broker/resources/ingress.go 97.36% <0.00%> (+0.25%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9a633...851b457. Read the comment docs.

Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@knative-prow
Copy link

knative-prow bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e1cf794 into knative-extensions:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RMQ Source docs out of date
2 participants