Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker / Trigger can use RabbitmqBrokerConfig or a RabbitMQCluster as its config #780

Merged
merged 2 commits into from
May 24, 2022

Conversation

gab-satchi
Copy link
Contributor

  • 🎁 rabbitmqBrokerConfig can be used as the new Broker.Spec.Config
  • 🧹 remove broker_config and added a new service to fetch broker configs for Triggers & Brokers

/kind enhancement

- A new type RabbitmqBrokerConfig can be used to configure a Broker

/hold for tests

docs to follow

… its config

- adds brokerConfig service to dedupe between Trigger and Broker
@knative-prow knative-prow bot added kind/enhancement do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #780 (7a2f737) into main (0e8a6cf) will decrease coverage by 0.58%.
The diff coverage is 53.02%.

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   75.16%   74.57%   -0.59%     
==========================================
  Files          39       38       -1     
  Lines        2621     2525      -96     
==========================================
- Hits         1970     1883      -87     
+ Misses        585      576       -9     
  Partials       66       66              
Impacted Files Coverage Δ
pkg/reconciler/trigger/trigger.go 64.64% <43.22%> (-1.10%) ⬇️
pkg/reconciler/broker/broker.go 91.82% <88.00%> (+0.31%) ⬆️
pkg/apis/eventing/v1alpha1/broker_validation.go 83.75% <100.00%> (+0.63%) ⬆️
pkg/reconciler/broker/controller.go 95.65% <100.00%> (ø)
pkg/reconciler/trigger/controller.go 72.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8a6cf...7a2f737. Read the comment docs.

@gab-satchi
Copy link
Contributor Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@knative-prow
Copy link

knative-prow bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fb7c6d1 into knative-extensions:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants