Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s api to v0.27.6 and contour to 1.26.0 #974

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Bump k8s api to v0.27.6 and contour to 1.26.0 #974

merged 2 commits into from
Oct 12, 2023

Conversation

andrew-su
Copy link
Contributor

@andrew-su andrew-su commented Oct 4, 2023 •
edited
Loading

Changes

/kind enhancement

Fixes #960

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #974 (f18b0a0) into main (cf267c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files           7        7           
  Lines         802      802           
=======================================
  Hits          753      753           
  Misses         28       28           
  Partials       21       21

@andrew-su
Copy link
Contributor Author

/test build-tests

@andrew-su andrew-su changed the title Bump contour to 1.26.0 draft: Bump contour to 1.26.0 Oct 4, 2023
@andrew-su andrew-su changed the title draft: Bump contour to 1.26.0 WIP: Bump contour to 1.26.0 Oct 4, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@andrew-su andrew-su changed the title WIP: Bump contour to 1.26.0 Bump contour to 1.26.0 Oct 5, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@andrew-su
Copy link
Contributor Author

/test integration-tests

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2023
@dprotaso
Copy link
Contributor

/hold - we should actually bump to the right k8s client-go version - for v1.12 that's 1.27.x

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@dprotaso
Copy link
Contributor

Might want to wait for this bump first

#973

@dprotaso
Copy link
Contributor

dprotaso commented Oct 11, 2023 •
edited
Loading

@andrew-su all the stuff has merged - so you're good to continue

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2023
@andrew-su
Copy link
Contributor Author

Updated.
I had chosen to use the same versions as what we currently have for the other k8s dependencies, however it looks like the codegen still work with:

	k8s.io/code-generator => k8s.io/code-generator v0.27.6
	k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f

Should I bump it to ^ or leave it for consistency?

@dprotaso
Copy link
Contributor

We can match serving with v0.27x deps. Next release we are targeting k8s min version of 1.26 which means we can use 1.27 libs

https://github.com/knative/serving/blob/6703812f131472daa5b7f17e60dd7f49a06c1ead/go.mod#L28

@andrew-su andrew-su changed the title Bump contour to 1.26.0 Bump k8s api to v0.27.6 and contour to 1.26.0 Oct 12, 2023
@andrew-su
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrew-su, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@knative-prow knative-prow bot merged commit c355640 into knative-extensions:main Oct 12, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlisia carlisia Awaiting requested review from carlisia

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Contour to v1.26
3 participants
@andrew-su @dprotaso @knative-prow-robot