Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] Bump to fix serving/#14732 #1177

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[release-1.11] Bump to fix serving/#14732 #1177

merged 1 commit into from
Dec 18, 2023

Conversation

dprotaso
Copy link
Contributor

@knative-prow knative-prow bot requested review from nak3 and ReToCode December 18, 2023 14:49
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
@dprotaso dprotaso mentioned this pull request Dec 18, 2023
Closed
14 tasks
ReToCode
ReToCode approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76ffa8f) 80.95% compared to head (da6c84a) 80.95%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.11    #1177   +/-   ##
=============================================
  Coverage         80.95%   80.95%           
=============================================
  Files                18       18           
  Lines              1355     1355           
=============================================
  Hits               1097     1097           
  Misses              205      205           
  Partials             53       53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit cede267 into knative-extensions:release-1.11 Dec 18, 2023
18 checks passed
@dprotaso dprotaso deleted the release-1.11 branch December 18, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@nak3 nak3 Awaiting requested review from nak3

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @ReToCode