Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable envoy server header injection #1311

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 4, 2024

Changes

  • Downstream users want to hide the server header. If there is no such header present in the response, by default Envoy injects its own that has the value envoy (based on the default server_name config). Envoy allows to configure when the server header is injected. Here we support only the option to prevent Envoy's header injection. In a secured environment probably this should be on by default.

/kind

Fixes #

Release Note

A new configuration option `disable-envoy-server-header` prevents Envoy server header from being injected when there is none such header in the response.

Copy link

knative-prow bot commented Dec 4, 2024

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Downstream users want to hide the server header. If there is no such header present in the response, by default Envoy injects its own that has the value envoy (based on the default server_name config). Envoy allows to configure when the server header is injected. Here we support only the option to prevent Envoy's header injection. In a secured environment probably this should be on by default.

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from izabelacg and ReToCode December 4, 2024 09:35
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (d661174) to head (2704cbb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   60.69%   60.83%   +0.13%     
==========================================
  Files          24       24              
  Lines        2005     2012       +7     
==========================================
+ Hits         1217     1224       +7     
  Misses        726      726              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
Copy link

knative-prow bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3cf7632 into knative-extensions:main Dec 4, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants