Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Remove the vendor dir #589

Closed
wants to merge 1 commit into from
Closed

🧹 Remove the vendor dir #589

wants to merge 1 commit into from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 27, 2023

Changes

  • 🧹 Remove the vendor dir

/kind cleanup

Related to knative/infra#134

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 27, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2023
@krsna-m
Copy link

krsna-m commented Sep 27, 2023

+1,199 −1,299,717 ❤️

I didn't dare load all the changes but why the 1.2k adds?

@krsna-m
Copy link

krsna-m commented Sep 27, 2023

this is top 10 cleanups ever on this project i am sure :P Thanks @cardil

@cardil
Copy link
Contributor Author

cardil commented Sep 27, 2023

+1,199 −1,299,717 ❤️

I didn't dare load all the changes but why the 1.2k adds?

This is because we still run the google/licenses save command, which unpacks LICENSES (and some sources to third-party folder)

See the knative/community#1441 (question to TOC)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2023
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@psschwei psschwei removed their request for review November 28, 2023 20:13
@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2024
@github-actions github-actions bot closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardil @krsna-m @knative-prow-robot