Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented message passing between FileWatcher and Vert.x #346

Merged

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Oct 26, 2020

Fixes #332

Proposed Changes

  • Introduces a bunch of classes to send/receive the contract using the event bus: ContractMessageCodec, ContractPublisher, ResourcesReconcilerMessageHandler
  • ConsumerDeployer becomes a verticle that has to be deployed to run. It starts the message consumer and the reconciler internally.
  • HttpVerticle in receiver changes a bit its role and becomes ReceiverVerticle. Now, more than being a mere http server starter, it knows about the receiver classes and starts the reconciler message consumer together with the http server. This aligns it with ConsumerDeployer usage and role and also keeps the reconciliation on the same verticle of the listener.
  • Renamed RequestReceiver to proper RequestMapper

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 26, 2020
@slinkydeveloper slinkydeveloper changed the title Implemented message passing between FileWatcher and vertx Implemented message passing between FileWatcher and Vert.x Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #346 into master will increase coverage by 0.22%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #346      +/-   ##
============================================
+ Coverage     76.05%   76.27%   +0.22%     
- Complexity      180      189       +9     
============================================
  Files            49       51       +2     
  Lines          1541     1564      +23     
  Branches         52       53       +1     
============================================
+ Hits           1172     1193      +21     
- Misses          289      291       +2     
  Partials         80       80              
Flag Coverage Δ Complexity Δ
#java-unittests 75.43% <75.00%> (+0.46%) 189.00 <23.00> (+9.00)
#unittests 76.27% <75.00%> (+0.22%) 189.00 <23.00> (+9.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...knative/eventing/kafka/broker/dispatcher/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...v/knative/eventing/kafka/broker/receiver/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fka/broker/core/eventbus/ContractMessageCodec.java 75.00% <75.00%> (ø) 5.00 <5.00> (?)
...enting/kafka/broker/receiver/ReceiverVerticle.java 92.59% <88.88%> (ø) 3.00 <3.00> (?)
.../kafka/broker/core/eventbus/ContractPublisher.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...nciler/impl/ResourcesReconcilerMessageHandler.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...ka/broker/dispatcher/ConsumerDeployerVerticle.java 82.22% <100.00%> (ø) 9.00 <3.00> (?)
.../eventing/kafka/broker/receiver/RequestMapper.java 94.59% <100.00%> (ø) 14.00 <4.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d16e3...d874660. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

flaky not related to this test
/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ReceiverVerticle doesn't know anymore about the probe decorator

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2020
@pierDipi
Copy link
Member

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@pierDipi
Copy link
Member

From the sacura job logs seems like not all events have been sent:

"status_codes": {
   "202": 119951
  },

It should be "202": 120k, so we have been slower to receive and/or consume events.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1253477 into knative-extensions:master Oct 27, 2020
@slinkydeveloper slinkydeveloper deleted the issues/332 branch October 27, 2020 10:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants