-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented message passing between FileWatcher and Vert.x #346
Implemented message passing between FileWatcher and Vert.x #346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
============================================
+ Coverage 76.05% 76.27% +0.22%
- Complexity 180 189 +9
============================================
Files 49 51 +2
Lines 1541 1564 +23
Branches 52 53 +1
============================================
+ Hits 1172 1193 +21
- Misses 289 291 +2
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
data-plane/tests/src/test/java/dev/knative/eventing/kafka/broker/tests/DataPlaneTest.java
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...est/java/dev/knative/eventing/kafka/broker/dispatcher/integration/UnorderedConsumerTest.java
Outdated
Show resolved
Hide resolved
...lane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/ReceiverVerticle.java
Outdated
Show resolved
Hide resolved
data-plane/tests/src/test/java/dev/knative/eventing/kafka/broker/tests/DataPlaneTest.java
Show resolved
Hide resolved
flaky not related to this test |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ReceiverVerticle doesn't know anymore about the probe decorator Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
8831f13
to
52dd086
Compare
...src/test/java/dev/knative/eventing/kafka/broker/dispatcher/ConsumerDeployerVerticleTest.java
Outdated
Show resolved
Hide resolved
...ev/knative/eventing/kafka/broker/core/reconciler/impl/ResourcesReconcilerMessageHandler.java
Outdated
Show resolved
Hide resolved
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests |
From the sacura job logs seems like not all events have been sent:
It should be |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
data-plane/tests/src/test/java/dev/knative/eventing/kafka/broker/tests/DataPlaneTest.java
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #332
Proposed Changes
ContractMessageCodec
,ContractPublisher
,ResourcesReconcilerMessageHandler
ConsumerDeployer
becomes a verticle that has to be deployed to run. It starts the message consumer and the reconciler internally.HttpVerticle
in receiver changes a bit its role and becomesReceiverVerticle
. Now, more than being a mere http server starter, it knows about the receiver classes and starts the reconciler message consumer together with the http server. This aligns it withConsumerDeployer
usage and role and also keeps the reconciliation on the same verticle of the listener.RequestReceiver
to properRequestMapper