-
Notifications
You must be signed in to change notification settings - Fork 83
Add Kafka Source defaults, starting with KEDA annotations #855
Add Kafka Source defaults, starting with KEDA annotations #855
Conversation
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 75.14% 74.64% -0.51%
==========================================
Files 139 143 +4
Lines 6442 6633 +191
==========================================
+ Hits 4841 4951 +110
- Misses 1369 1435 +66
- Partials 232 247 +15
Continue to review full report at Codecov.
|
Was this tested? I just deployed this change into pg1 and created a Kafka source from there. The annotations were not added. |
yes. What is pg1 :-) ? Anyway, did you change the configmap to enable annotations injection? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, steven0711dong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.25 |
@lionelvillard: #855 failed to apply on top of branch "release-0.25":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…s#855) Co-authored-by: Steven DOng <steven.dong@ibm.com>
Proposed Changes
Release Note
Docs
See knative/docs#4181
/cc @steven0711dong @matzew @zroubalik