Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dlq #453

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Remove unused dlq #453

merged 2 commits into from
Oct 20, 2021

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Oct 6, 2021

Changes

  • 🐛 Don't create a queue for the broker's DLQ exchange unless the broker has a dead letter sink

/kind bug

Fixes #391

Release Note

Brokers will no longer create a queue for dead-lettered events if no dead letter sink is defined

@knative-prow-robot knative-prow-robot added kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2021
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2021
@benmoss
Copy link
Contributor Author

benmoss commented Oct 6, 2021

Built on top of #449, so let's get that merged first

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #453 (72fba3c) into main (95462cf) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   75.85%   75.94%   +0.09%     
==========================================
  Files          44       44              
  Lines        2663     2673      +10     
==========================================
+ Hits         2020     2030      +10     
  Misses        522      522              
  Partials      121      121
Impacted Files Coverage Δ
pkg/reconciler/broker/broker.go 89.61% <100.00%> (+0.23%) ⬆️
pkg/reconciler/broker/broker_lifecycle.go 80.00% <100.00%> (+2.22%) ⬆️
pkg/reconciler/broker/broker_test_helper.go 78.12% <100.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95462cf...72fba3c. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2021
Only create exchange DLQ queue when needed
ebfb24f 
Otherwise it will fill up with dead-lettered messages, with no one
listening on it
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2021
@benmoss
Copy link
Contributor Author

benmoss commented Oct 12, 2021

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2021
Remove unused const
72fba3c 
Missed this in knative-extensions#449 it seems
@gvmw
Copy link
Contributor

gvmw commented Oct 13, 2021

This looks good to me 👍🏻

/lgtm

@knative-prow-robot
Copy link

@gvmw: changing LGTM is restricted to collaborators

In response to this:

This looks good to me 👍🏻

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benmoss benmoss mentioned this pull request Oct 14, 2021
Merged
@benmoss
Copy link
Contributor Author

benmoss commented Oct 20, 2021

/assign @salaboy @gabo1208

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 07e1618 into knative-extensions:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 approved these changes

Assignees

@salaboy salaboy

@gabo1208 gabo1208

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrouteable messages are always sent to a DLQ
5 participants
@benmoss @gvmw @knative-prow-robot @gabo1208 @salaboy