Adding label

[VeerMuchandi]

In what area(s)?

kn command line option

Classifications:

/kind feature

Describe the feature:

Ability to add user defined labels to the service and its artifacts. Certain implementation specific features depend on labels. Being able to add a label with kn will avoid additional overhead of unnecessarily updating the service (and avoiding a new revision) just for adding a label.

Example
kn service create myservice --label=app.kubernetes.io/part-of=mygroup

[rhuss]

Same question as for #327: Where to add the labels ? Service, Pod or both ?

Regardless what the behaviour must be consistent regarding to labels and annotations.

[sixolet]

/assign aaron-lerner

[knative-prow-robot]

@sixolet: GitHub didn't allow me to assign the following users: aaron-lerner.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign aaron-lerner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VeerMuchandi]

Applying to knative service will trickle down to the pods as well. Here is an example of labels and annotations applied to the service. https://raw.githubusercontent.com/VeerMuchandi/catalystdemo/master/serverless/todo-serverless.yaml

…

On Mon, Aug 5, 2019 at 4:48 AM Roland Huß ***@***.***> wrote: Same question as for #327 <#327>: Where to add the labels ? Service, Pod or both ? Regardless what the behaviour must be consistent regarding to labels and annotations. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#328?email_source=notifications&email_token=ABRVS75XH2VRPSMYFG4IMO3QC7SOHA5CNFSM4II6437KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3REHFY#issuecomment-518144919>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRVS77GLX64XEUNA6PNPODQC7SOHANCNFSM4II6437A> .

[markusthoemmes]

@VeerMuchandi I don't think that's accurate. Your example has the labels in the revisionTemplate, not as part of the Service's ObjectMeta itself. I don't think labels in ObjectMeta propagate down.

[VeerMuchandi]

Thanks Markus I understood the question differently. I thought configuration, revision and route were being created separately based on the question. I meant it was part of the service's yaml and yes it is part of the spec.template.metadata and this applies both to labels and annotations.

…

On Wed, Aug 7, 2019 at 6:31 AM Markus Thömmes ***@***.***> wrote: @VeerMuchandi <https://github.com/VeerMuchandi> I don't think that's accurate. Your example has the labels in the revisionTemplate, not as part of the Service's ObjectMeta itself. I don't think labels in ObjectMeta propagate down. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#328?email_source=notifications&email_token=ABRVS76KE3IJXY6YDY4OSMDQDKP6JA5CNFSM4II6437KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3X6WNY#issuecomment-519039799>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRVS7ZPNB7XD3LB5P4BMDTQDKP6JANCNFSM4II6437A> .

[navidshaikh]

/assign