Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Upgrade to latest dependencies #1207

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Jan 28, 2021

Cron. -knative-prow-robot

/cc knative/client-wg-leads
/assign knative/client-wg-leads

Produced via:

./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:

bumping knative.dev/hack 8d623a0...8368e1f:
  > 8368e1f guard against set -o unset (# 49)
  > 2b4f6fc disable go's proxy and sumdb only for knative deps (# 47)
bumping knative.dev/networking 8b522a9...e24bdfe:
  > e24bdfe upgrade to latest dependencies (# 350)
  > ab1235e Bump a few assorted dependencies to their latest versions (# 349)
  > 45b7ed1 Add ingress conformance test to ensure we do not add retries (# 348)
  > b61da13 upgrade to latest dependencies (# 347)
  > d2088ff Update common github actions (# 346)
  > c069ad2 Create prober request with context right away (# 344)
  > 342a3fb upgrade to latest dependencies (# 342)
  > 94433ab upgrade to latest dependencies (# 341)
bumping knative.dev/pkg 6040b3a...a02dcff:
  > a02dcff Bump a few assorted dependencies to their latest versions (# 2013)
  > 4b2ae07 Replace deprecated github.com/markbates/inflect with github.com/gobuffalo/flect (# 2014)
  > 8878069 upgrade to latest dependencies (# 2010)
  > c493a9e Update common github actions (# 2009)
  > 6045ed4 Allow setting DisableCompression in NewAutoTransport (# 2007)
  > ca02ef7 Genreconciler properly generates reconciler for Resources with Status (# 2004)
  > 0d31134 Fix nil pointer panic in kvstore (# 2002)
bumping knative.dev/serving e61294b...8751d91:
  > 8751d91 Split the reconcile rollout into its own function (# 10722)
  > 2b95084 Optimize the execution path around logging (# 10720)
  > bbca20f Update net-contour nightly (# 10715)
  > ef39273 upgrade to latest dependencies (# 10719)
  > 6449fb8 upgrade to latest dependencies (# 10717)
  > 45a435a Update net-kourier nightly (# 10706)
  > 2fbef5f upgrade to latest dependencies (# 10713)
  > c4ea4ad Fix the analyzer config for load-testing benchmark since it must have a value (# 10709)
  > 6f46354 Apply k8s default values for readiness probe (# 10700)
  > 8c4b2ff Update net-certmanager nightly (# 10705)
  > b6f618b Update net-istio nightly (# 10704)
  > 390f2c2 bump k8s min in DEVELOPMENT.md (# 10699)
  > f2ccdd5 tests (# 10702)
  > 2090edf Update net-istio nightly (# 10695)
  > 789455d Update net-certmanager nightly (# 10674)
  > 1c61d3b Update common github actions (# 10697)
  > 2bc3650 Update net-kourier nightly (# 10696)
  > 8c64d92 Format markdown (# 10698)
  > 0e77ab2 Update net-kourier nightly (# 10676)
  > dd96a0a Update net-contour nightly (# 10686)
  > 8fbcfb0 Unpin the istio version and temporarily disable the error rate check analyzer (# 10655)
  > 58550fd Avoid adding gzip-encoding to requests implicitly (# 10691)
  > 60cdc35 Move Multi Container test to Beta (# 10683)
  > ae7b278 Update net-istio nightly (# 10687)
  > 7a18f38 Fix some nits in e2e tests (# 10678)
  > 9c572cd Allow to specify build platform for test images (# 10672)
  > 0ee79dd Remove the unsed struct items (# 10684)
  > 29da3af Improve debuggability of SKS logs (# 10679)
  > 8e1d587 upgrade to latest dependencies (# 10682)
  > aef0145 Temporarily disable auto TLS test with HTTP01 challenge  (# 10685)
  > 32b0292 Use lister instead of client to directly get ClusterDomainClaim (# 10677)
  > a19ff15 Update net-istio nightly (# 10675)
  > 6313088 Allow kpa to work with timeout in context (# 10673)
  > af7af61 Perform some test helper cleanup (# 10670)
  > 93d2449 upgrade to latest dependencies (# 10671)
  > 888331e Remove the service name from the internal traffic target object. (# 10669)
  > 1901e4c Use consistent alias for autoscaler v1alpha1 everywhere (# 10666)
  > 1e070a3 Remove context from MakeDecider (# 10657)
  > 452bed5 Further remove usage of the context in the scale runner (# 10653)
  > a1ee2ec bump ggcr & k8schain (# 10651)
  > 81818f9 Fix logging of errors in stats scraper (# 10654)
  > 1b0f43c Hide implementation detail inside a function (# 10652)
  > 756fd17 Update net-istio nightly (# 10648)
  > 6d46d52 Add support for decoding Revision from Host. (# 10647)
  > 01fa1a0 Remove the time computation (# 10645)
  > dbccf2a Do not pass context to the scale, but logger instead (# 10646)
  > ab176fa Rename back to the non deprecated name (# 10640)
  > fae6549 Update net-contour nightly (# 10644)
  > 5cd4f64 Update net-istio nightly (# 10643)
  > fbbbb98 Make route stop using the `DeprecatedServiceName` field (# 10638)
  > bf35e3f :lipstick: updating the HPAs to v2beta2 API usage (# 10631)
  > 51a9c0b Update net-certmanager nightly (# 10636)
  > e5c5c08 Export MESH env value in test script (# 10635)
  > 4a3274c Remove unused constants, make some other small tidy-ups (# 10637)
  > b083383 fix the broken doc's link (# 10634)
  > aac0df2 Deprecate the service name on the revision. (# 10633)
  > 0aa3d0b Remove the propagation from SKS->PA->Rev.Status of the K8s service (# 10632)
  > db90f4f Update net-contour nightly (# 10597)
  > 981c601 Update net-istio nightly (# 10619)
  > 8922f35 Update net-kourier nightly (# 10599)
  > df11c15 chore: Set background to white for autoscaling diagrams ... (# 10629)
  > f637b5a Remove naked returns (# 10618)
  > 6cde241 Improve rollout test to check duration (# 10625)
  > 7700811 At 100ms we still see failures on prow (# 10626)
  > c081a82 Make the singlethreaded code simpler by using boolean guard (# 10624)
  > 55a7edf upgrade to latest dependencies (# 10627)
  > 53d4d5b Fix some annoying nits in the route e2e tests (# 10623)
  > 2c781c7 upgrade to latest dependencies (# 10620)
  > 6dba44a The year was 2021.. (# 10621)
  > 39d33bf upgrade to latest dependencies (# 10617)
bumping golang.org/x/term 7de9c90...2321bbc:
  > 2321bbc Update doc to use "term" instead of "terminal"
  > ee85cb9 README.md: add badge to pkg.go.dev
bumping knative.dev/eventing ea452b5...3fcb645:
  > 3fcb645 :cyclone: Remvoing contrib refs (# 4855)
  > f05561d upgrade to latest dependencies (# 4853)
  > 37eaf71 switch Harwayne with antoineco (# 4850)
  > b887ac4 upgrade to latest dependencies (# 4848)
  > daa085d Format markdown (# 4846)
  > 3d51c72 Change trigger spec to indicate assigned broker should be immutable (# 4828)
  > 1774243 Add immutable fields validation to v1beta1 broker (# 4816)
  > 935d5fb Format markdown (# 4840)
  > 269b061 Update common github actions (# 4839)
  > 152e608 upgrade to latest dependencies (# 4841)
  > 8171448 Adding Logline for when a cloudevent has been successfully sent from APIServerSource to the sink (# 4723)
  > fd2688d Use SHOULD for TriggerSpec to keep compatibility (# 4838)
  > 1fa597e [# 4796] Bump golang lint timeout to 10m (# 4830)
  > a4a9f48 Format markdown (# 4829)
  > d58bd38 fix the link to head (# 4826)
  > 39d7a9e remove unused functions (# 4824)
  > 6edcbdd Panic in shared main to propagate error to exit code (# 4820)
  > 012a9bd v1beta1.Trigger delivery should be v1.DeliverySpec (# 4822)
  > 321a839 Format markdown (# 4823)
  > ec63881 Fix spec # 4515 (# 4654)
  > 1528750 upgrade to latest dependencies (# 4818)
  > 9dc57e2 Update common github actions (# 4817)
  > b20c96b sinkbing implement bindable (# 4794)
  > 8d51418 Bump golang linter version and timeout (# 4808)
  > f882ff0 Add availability rate to upgrade test report (# 4555)
  > a6635bb Patch HPA eventing-webhook min replicas (# 4811)
  > d46c1d0 It is already 2021 (# 4809)
  > fb8fbf7 Adding new source conformance testcase for CRD RBAC (# 4787)
  > 1725902 Update COMMUNITY_CONTACTS.md test grid link (# 4798)
  > b75d03a Adding new source conformance testcase for CRD Source Registry Spec (# 4780)
  > 77fc350 upgrade to latest dependencies (# 4797)

@knative-prow-robot knative-prow-robot requested a review from a team January 28, 2021 13:40
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 28, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2021
@dsimansk
Copy link
Contributor

For any reviewer, please take a look at the PR #1208 first.

@knative-automation knative-automation force-pushed the auto-updates/update-deps-master branch 2 times, most recently from a4162ab to 76d2e17 Compare January 29, 2021 13:43
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/retest

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2021
@dsimansk
Copy link
Contributor

dsimansk commented Feb 1, 2021

 vendor/sigs.k8s.io/kustomize/pkg/transformers/config/factorycrd.go:71:47: cannot use api.Schema.SchemaProps.Properties (type spec.SchemaProperties) as type myProperties in argument to looksLikeAk8sType 

The error is cause by incompatible go-openapi/spec dependency pulled from Serving update.

Since go-openapi v0.19.9 the Properties type is changed(generated as) SchemaProperties vs. the previous one. However, it's not compatible with sigs.k8s.io/kustomize that seems to be used only in kn code.

We should probably pin the go-openapi version for now. Wdyt? @rhuss

@rhuss
Copy link
Contributor

rhuss commented Feb 1, 2021

@dsimansk Good point. But I wonder why we are importing kustomize code. And if this is really needed the next question would be whether we could align this version with the upstream dependency.

@dsimansk
Copy link
Contributor

dsimansk commented Feb 1, 2021

It's a transitive dependency of k8s.io/cli-runtime that we use for genericclioptions mainly printable flag etc.

It's pinned to v2.0.3 which's pretty old therefore it doesn't behave well with newer go-openapi/spec. I've seen some comments to isolate kustomize completely, but that seems like a longterm effort.

kubernetes-sigs/kustomize#3262
kubernetes-sigs/kustomize#1500
kubernetes-sigs/kustomize#2506

@dsimansk
Copy link
Contributor

dsimansk commented Feb 2, 2021

/retest

@knative-automation knative-automation force-pushed the auto-updates/update-deps-master branch 3 times, most recently from 1332864 to b51cf4a Compare February 3, 2021 13:36
@dsimansk
Copy link
Contributor

dsimansk commented Feb 3, 2021

/retest

@dsimansk
Copy link
Contributor

dsimansk commented Feb 4, 2021

With the upgraded dependencies there's one more golangci-lint issue to address:

Error: SA1019: package golang.org/x/crypto/ssh/terminal is deprecated: this package moved to golang.org/x/term.  (staticcheck)

@knative-automation knative-automation force-pushed the auto-updates/update-deps-master branch 3 times, most recently from 50b19de to 9628ad3 Compare February 5, 2021 01:45
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
@knative-automation knative-automation force-pushed the auto-updates/update-deps-master branch 2 times, most recently from 0a92284 to e21abb0 Compare February 9, 2021 01:45
@navidshaikh
Copy link
Collaborator

/test pull-knative-client-integration-tests

bumping knative.dev/hack 8d623a0...8368e1f:
  > 8368e1f guard against set -o unset (# 49)
  > 2b4f6fc disable go's proxy and sumdb only for knative deps (# 47)
bumping knative.dev/networking 8b522a9...e24bdfe:
  > e24bdfe upgrade to latest dependencies (# 350)
  > ab1235e Bump a few assorted dependencies to their latest versions (# 349)
  > 45b7ed1 Add ingress conformance test to ensure we do not add retries (# 348)
  > b61da13 upgrade to latest dependencies (# 347)
  > d2088ff Update common github actions (# 346)
  > c069ad2 Create prober request with context right away (# 344)
  > 342a3fb upgrade to latest dependencies (# 342)
  > 94433ab upgrade to latest dependencies (# 341)
bumping knative.dev/pkg 6040b3a...a02dcff:
  > a02dcff Bump a few assorted dependencies to their latest versions (# 2013)
  > 4b2ae07 Replace deprecated github.com/markbates/inflect with github.com/gobuffalo/flect (# 2014)
  > 8878069 upgrade to latest dependencies (# 2010)
  > c493a9e Update common github actions (# 2009)
  > 6045ed4 Allow setting DisableCompression in NewAutoTransport (# 2007)
  > ca02ef7 Genreconciler properly generates reconciler for Resources with Status (# 2004)
  > 0d31134 Fix nil pointer panic in kvstore (# 2002)
bumping knative.dev/serving e61294b...8751d91:
  > 8751d91 Split the reconcile rollout into its own function (# 10722)
  > 2b95084 Optimize the execution path around logging (# 10720)
  > bbca20f Update net-contour nightly (# 10715)
  > ef39273 upgrade to latest dependencies (# 10719)
  > 6449fb8 upgrade to latest dependencies (# 10717)
  > 45a435a Update net-kourier nightly (# 10706)
  > 2fbef5f upgrade to latest dependencies (# 10713)
  > c4ea4ad Fix the analyzer config for load-testing benchmark since it must have a value (# 10709)
  > 6f46354 Apply k8s default values for readiness probe (# 10700)
  > 8c4b2ff Update net-certmanager nightly (# 10705)
  > b6f618b Update net-istio nightly (# 10704)
  > 390f2c2 bump k8s min in DEVELOPMENT.md (# 10699)
  > f2ccdd5 tests (# 10702)
  > 2090edf Update net-istio nightly (# 10695)
  > 789455d Update net-certmanager nightly (# 10674)
  > 1c61d3b Update common github actions (# 10697)
  > 2bc3650 Update net-kourier nightly (# 10696)
  > 8c64d92 Format markdown (# 10698)
  > 0e77ab2 Update net-kourier nightly (# 10676)
  > dd96a0a Update net-contour nightly (# 10686)
  > 8fbcfb0 Unpin the istio version and temporarily disable the error rate check analyzer (# 10655)
  > 58550fd Avoid adding gzip-encoding to requests implicitly (# 10691)
  > 60cdc35 Move Multi Container test to Beta (# 10683)
  > ae7b278 Update net-istio nightly (# 10687)
  > 7a18f38 Fix some nits in e2e tests (# 10678)
  > 9c572cd Allow to specify build platform for test images (# 10672)
  > 0ee79dd Remove the unsed struct items (# 10684)
  > 29da3af Improve debuggability of SKS logs (# 10679)
  > 8e1d587 upgrade to latest dependencies (# 10682)
  > aef0145 Temporarily disable auto TLS test with HTTP01 challenge  (# 10685)
  > 32b0292 Use lister instead of client to directly get ClusterDomainClaim (# 10677)
  > a19ff15 Update net-istio nightly (# 10675)
  > 6313088 Allow kpa to work with timeout in context (# 10673)
  > af7af61 Perform some test helper cleanup (# 10670)
  > 93d2449 upgrade to latest dependencies (# 10671)
  > 888331e Remove the service name from the internal traffic target object. (# 10669)
  > 1901e4c Use consistent alias for autoscaler v1alpha1 everywhere (# 10666)
  > 1e070a3 Remove context from MakeDecider (# 10657)
  > 452bed5 Further remove usage of the context in the scale runner (# 10653)
  > a1ee2ec bump ggcr & k8schain (# 10651)
  > 81818f9 Fix logging of errors in stats scraper (# 10654)
  > 1b0f43c Hide implementation detail inside a function (# 10652)
  > 756fd17 Update net-istio nightly (# 10648)
  > 6d46d52 Add support for decoding Revision from Host. (# 10647)
  > 01fa1a0 Remove the time computation (# 10645)
  > dbccf2a Do not pass context to the scale, but logger instead (# 10646)
  > ab176fa Rename back to the non deprecated name (# 10640)
  > fae6549 Update net-contour nightly (# 10644)
  > 5cd4f64 Update net-istio nightly (# 10643)
  > fbbbb98 Make route stop using the `DeprecatedServiceName` field (# 10638)
  > bf35e3f 💄 updating the HPAs to v2beta2 API usage (# 10631)
  > 51a9c0b Update net-certmanager nightly (# 10636)
  > e5c5c08 Export MESH env value in test script (# 10635)
  > 4a3274c Remove unused constants, make some other small tidy-ups (# 10637)
  > b083383 fix the broken doc's link (# 10634)
  > aac0df2 Deprecate the service name on the revision. (# 10633)
  > 0aa3d0b Remove the propagation from SKS->PA->Rev.Status of the K8s service (# 10632)
  > db90f4f Update net-contour nightly (# 10597)
  > 981c601 Update net-istio nightly (# 10619)
  > 8922f35 Update net-kourier nightly (# 10599)
  > df11c15 chore: Set background to white for autoscaling diagrams ... (# 10629)
  > f637b5a Remove naked returns (# 10618)
  > 6cde241 Improve rollout test to check duration (# 10625)
  > 7700811 At 100ms we still see failures on prow (# 10626)
  > c081a82 Make the singlethreaded code simpler by using boolean guard (# 10624)
  > 55a7edf upgrade to latest dependencies (# 10627)
  > 53d4d5b Fix some annoying nits in the route e2e tests (# 10623)
  > 2c781c7 upgrade to latest dependencies (# 10620)
  > 6dba44a The year was 2021.. (# 10621)
  > 39d33bf upgrade to latest dependencies (# 10617)
bumping golang.org/x/term 7de9c90...2321bbc:
  > 2321bbc Update doc to use "term" instead of "terminal"
  > ee85cb9 README.md: add badge to pkg.go.dev
bumping knative.dev/eventing ea452b5...3fcb645:
  > 3fcb645 🌀 Remvoing contrib refs (# 4855)
  > f05561d upgrade to latest dependencies (# 4853)
  > 37eaf71 switch Harwayne with antoineco (# 4850)
  > b887ac4 upgrade to latest dependencies (# 4848)
  > daa085d Format markdown (# 4846)
  > 3d51c72 Change trigger spec to indicate assigned broker should be immutable (# 4828)
  > 1774243 Add immutable fields validation to v1beta1 broker (# 4816)
  > 935d5fb Format markdown (# 4840)
  > 269b061 Update common github actions (# 4839)
  > 152e608 upgrade to latest dependencies (# 4841)
  > 8171448 Adding Logline for when a cloudevent has been successfully sent from APIServerSource to the sink (# 4723)
  > fd2688d Use SHOULD for TriggerSpec to keep compatibility (# 4838)
  > 1fa597e [# 4796] Bump golang lint timeout to 10m (# 4830)
  > a4a9f48 Format markdown (# 4829)
  > d58bd38 fix the link to head (# 4826)
  > 39d7a9e remove unused functions (# 4824)
  > 6edcbdd Panic in shared main to propagate error to exit code (# 4820)
  > 012a9bd v1beta1.Trigger delivery should be v1.DeliverySpec (# 4822)
  > 321a839 Format markdown (# 4823)
  > ec63881 Fix spec # 4515 (# 4654)
  > 1528750 upgrade to latest dependencies (# 4818)
  > 9dc57e2 Update common github actions (# 4817)
  > b20c96b sinkbing implement bindable (# 4794)
  > 8d51418 Bump golang linter version and timeout (# 4808)
  > f882ff0 Add availability rate to upgrade test report (# 4555)
  > a6635bb Patch HPA eventing-webhook min replicas (# 4811)
  > d46c1d0 It is already 2021 (# 4809)
  > fb8fbf7 Adding new source conformance testcase for CRD RBAC (# 4787)
  > 1725902 Update COMMUNITY_CONTACTS.md test grid link (# 4798)
  > b75d03a Adding new source conformance testcase for CRD Source Registry Spec (# 4780)
  > 77fc350 upgrade to latest dependencies (# 4797)

Signed-off-by: Knative Automation <automation@knative.team>
@navidshaikh
Copy link
Collaborator

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@knative-prow-robot knative-prow-robot merged commit 72aeb1c into knative:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants