Add support for providing sink spec in GVR format #1717
Conversation
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@vyasgun: 0 warnings.
In response to this:
Description
Changes
- The user can specify the sink with custom resource types
- Follows the format:
prefix:name:namespacewhere prefix is the group version resourceReference
Fixes #1704
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow
bot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 79.91% 79.90% -0.01%
==========================================
Files 174 174
Lines 13515 13529 +14
==========================================
+ Hits 10800 10811 +11
- Misses 1978 1979 +1
- Partials 737 739 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/kind enhancement |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vyasgun if you could take a look at some more unit test please, in a follow-up PR. |
|
Follow up PR for unit tests: #1724 |
Description
Changes
prefix:name:namespacewhere prefix is the group version resourceReference
Fixes #1704
Release Note