-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli options to enable user, uid, and group impersonation #1745
Conversation
Welcome @a7i! It looks like this is your first PR to knative/client 🎉 |
Hi @a7i. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a7i: 0 warnings.
In response to this:
Description
CLI options to enable kubernetes user and group impersonation
❯ ./kn options The following options can be passed to any command: --as string username to impersonate for the operation --as-group stringArray group to impersonate for the operation, this flag can be repeated to specify multiple groups --cluster string name of the kubeconfig cluster to use --config string kn configuration file (default: ~/.config/kn/config.yaml) --context string name of the kubeconfig context to use --kubeconfig string kubectl configuration file (default: ~/.kube/config) --log-http log http traffic
Changes
- provide string option
--as
for username impersonation- provide stringArray option
--as-group
for group impersonationReference
Fixes #
Release Note
provide cli options to enable Kubernetes user and group impersonation via `--as` and `--as-group` flags
- 🎁 New feature: provide cli options to enable Kubernetes user and group impersonation via
--as
and--as-group
flags
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test |
@a7i thanks for the PR! Looks good at a first glance! Can you pls take a look at failing unit test? https://github.com/knative/client/actions/runs/3212622694/jobs/5277761586#step:7:20 |
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
3cc8f84
to
fca4dce
Compare
7977647
to
4dcf7c7
Compare
Codecov ReportBase: 79.87% // Head: 79.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
+ Coverage 79.87% 79.89% +0.01%
==========================================
Files 174 174
Lines 13577 13589 +12
==========================================
+ Hits 10845 10857 +12
Misses 1990 1990
Partials 742 742
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
CLI options to enable kubernetes user and group impersonation
Changes
--as
for username impersonation--as-uid
for uid impersonation--as-group
for group impersonationReference
Fixes #
Release Note
--as
and--as-group
flags