Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated v1alpha1 DomainMapping API to newer one #1856

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

xiangpingjiang
Copy link
Contributor

@xiangpingjiang xiangpingjiang commented Aug 22, 2023

Description

Changes

Reference

Fixes #1854

Release Note

🐣 Upgrade deprecated `v1alpha1` DomainMapping API to `v1beta1`

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangpingjiang: 0 warnings.

In response to this:

Description

Changes

Reference

Fixes #1854

Release Note

- 🐣 Upgrade deprecated v1alpha1 DomainMapping API to newer one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2023
@dsimansk dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 22, 2023
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2023
pkg/kn/commands/completion_helper.go Outdated Show resolved Hide resolved
@xiangpingjiang
Copy link
Contributor Author

/retest

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
@xiangpingjiang
Copy link
Contributor Author

/retest

Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiangpingjiang!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9676e46) 79.64% compared to head (5734670) 79.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1856   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files         179      179           
  Lines       13938    13938           
=======================================
  Hits        11101    11101           
  Misses       2070     2070           
  Partials      767      767           
Files Changed Coverage Δ
pkg/kn/commands/completion_helper.go 85.54% <100.00%> (ø)
pkg/kn/commands/domain/create.go 75.51% <100.00%> (ø)
pkg/kn/commands/domain/delete.go 80.00% <100.00%> (ø)
pkg/kn/commands/domain/describe.go 77.27% <100.00%> (ø)
pkg/kn/commands/domain/human_readable_flags.go 83.78% <100.00%> (ø)
pkg/kn/commands/domain/list.go 66.66% <100.00%> (ø)
pkg/kn/commands/domain/update.go 60.86% <100.00%> (ø)
pkg/kn/commands/types.go 82.60% <100.00%> (ø)
pkg/serving/v1beta1/client.go 85.71% <100.00%> (ø)
pkg/serving/v1beta1/client_mock.go 88.09% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 494fe87 into knative:main Aug 22, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade deprecated v1alpha1 DomainMapping API to newer one
2 participants