Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected version for kn create kafka channel #1886

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Corrected version for kn create kafka channel #1886

merged 3 commits into from
Nov 30, 2023

Conversation

MeenuyD
Copy link
Contributor

@MeenuyD MeenuyD commented Oct 28, 2023 •
edited by dsimansk
Loading

Corrected version for kn create Kafka channel to v1beta1
Fixes #1885

Release Note

Fix version string of Kafka resources in examples

@knative-prow
Copy link

knative-prow bot commented Oct 28, 2023

Welcome @MeenuyD! It looks like this is your first PR to knative/client 🎉

@knative-prow
Copy link

knative-prow bot commented Oct 28, 2023

Hi @MeenuyD. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2023
@rhuss
Copy link
Contributor

rhuss commented Oct 31, 2023

Thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MeenuyD, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cef926d) 79.20% compared to head (bcd71e5) 79.20%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1886   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files         180      180           
  Lines       14075    14075           
=======================================
  Hits        11148    11148           
  Misses       2155     2155           
  Partials      772      772

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 31, 2023

/retest-required

2 similar comments
@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 31, 2023

/retest-required

@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 31, 2023

/retest-required

@rhuss
Copy link
Contributor

rhuss commented Oct 31, 2023

It looks like that the .md file have been updated manually but some has been missed. Please call ./hack/build.sh -c to recreate all doc files

@rhuss
Copy link
Contributor

rhuss commented Oct 31, 2023

(you can see this also in the logs of the failing test)

@dsimansk
Copy link
Contributor

dsimansk commented Nov 1, 2023 •
edited
Loading

@MeenuyD can you pls run ./hack/build.sh -c? That should produce .md files update in doc/ dir. Thanks!

@dsimansk
Copy link
Contributor

dsimansk commented Nov 1, 2023

/retest

@dsimansk
Copy link
Contributor

dsimansk commented Nov 1, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2023
@dsimansk
Copy link
Contributor

dsimansk commented Nov 1, 2023 •
edited
Loading

@MeenuyD can you pls run ./hack/build.sh -c? That should produce .md files update in doc/ dir. Thanks!

Ahh I see, look at sources for channel create and subscription create commands. There's old version reference in the examples as well.

https://github.com/knative/client/blob/main/pkg/kn/commands/channel/create.go#L45

@Leo6Leo
Copy link
Member

Leo6Leo commented Nov 1, 2023 •
edited
Loading

@MeenuyD Also one more minor thing, could you modify the PR description to add the keyword "Fixes #<the issue number that you are trying to fix>"? So that GitHub will automatically link this PR with that issue. When this PR is merged, that issue will be automatically closed too.

FYI, here is the doc for GitHub on how to use the "Fixes" keyword.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
rhuss
rhuss reviewed Nov 1, 2023
View reviewed changes
pkg/kn/commands/subscription/create.go Outdated
@@ -26,7 +26,6 @@ import (
"knative.dev/client/pkg/kn/commands"
"knative.dev/client/pkg/kn/commands/flags"
knflags "knative.dev/client/pkg/kn/flags"
knmessagingv1 "knative.dev/client/pkg/messaging/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this line seems to break the tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i remove this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's used here:

client/pkg/kn/commands/subscription/create.go

Line 73 in a7418fd

sb := knmessagingv1.NewSubscriptionBuilder(name)

Copy link
Contributor

@dsimansk dsimansk Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the example message needs to be changed in the source. Imports should be untouched, i.e. not needed to be changed at all.

@dsimansk dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 2, 2023
@dsimansk dsimansk removed the request for review from itsmurugappan November 30, 2023 10:08
@dsimansk
Copy link
Contributor

@MeenuyD I've fixed the nit preventing the build to pass. I hope you don't mind.

Thanks for contribution!

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow knative-prow bot merged commit 5b33d70 into knative:main Nov 30, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@rhuss rhuss

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong version for kn create kafka channel
4 participants
@MeenuyD @rhuss @Leo6Leo @dsimansk