Add support for Profiles

[sharmaansh21]

Description

This PR adds support for creating profiles for annotation and labels. A "profile" is a named collection of such meta-data that can be selected when creating or updating Knative services.

Changes

Added a flag for adding a profile while creating or updating the service. Also added a built-in profile, Istio.

Reference

Fixes #1890

Release Note

Added support for the --profile flag, which will add the related annotations and labels to the service.

[knative-prow]

Welcome @sharmaansh21! It looks like this is your first PR to knative/client 🎉

[knative-prow]

Hi @sharmaansh21. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (7b11654) 79.20% compared to head (93a6280) 79.21%.

Files	Patch %	Lines
...kg/kn/commands/service/configuration_edit_flags.go	83.01%	6 Missing and 3 partials ⚠️
pkg/kn/config/config.go	81.08%	5 Missing and 2 partials ⚠️
pkg/kn/config/testing.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
+ Coverage   79.20%   79.21%   +0.01%     
==========================================
  Files         180      180              
  Lines       14075    14166      +91     
==========================================
+ Hits        11148    11222      +74     
- Misses       2155     2167      +12     
- Partials      772      777       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsimansk]

/ok-to-test
/wip

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sharmaansh21 / name: Anshul Sharma (b0690fc, 9cff5ef, e2b3387, 93a6280)
• ✅ login: rhuss / name: Roland Huß (a476ba6)
• ✅ login: dsimansk / name: David Simansky (1060d21, 82886e9)

[dsimansk]

@sharmaansh21: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
build-tests_client_main 8752d02 link true /test build-tests

Your PR dashboard.

For this failure rerun ./hack/build.sh -c to generate new docs .md files pls.

[sharmaansh21]

/retest-required

[dsimansk]

Unrelated flake

/retest

[dsimansk]

The PR looks quiet complete to me. I've added one or two more suggestions, of course. :)

Great work with additional tweaks, plus decent test coverage!

Pls bring back the PR template into PR description. Hence it makes easier to generate release notes.
https://github.com/knative/client/blob/main/.github/pull-request-template.md

[sharmaansh21]

@dsimansk Thank you for quickly reviewing it; I incorporated all the feedback that you asked :)

[dsimansk]

/retest

[dsimansk]

Sorry for the delay, I was out of office during last week. IMO the PR looks good. I'm going to stamp it. Feel free to capture any further thoughts/enhancements in new issue.

Thanks for contribution and great Hackathon event!

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, sharmaansh21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment