-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor codegen to use kube_codegen.sh script #1964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsimansk: 0 warnings.
In response to this:
Description
Changes
- Refactor codegen to use kube_codegen.sh script
Align with rest of components reusing K8s.io codegen tooling.
Reference
Fixes #
Release Note
Refactor codegen to use kube_codegen.sh script
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
=======================================
Coverage 75.78% 75.78%
=======================================
Files 228 228
Lines 13411 13411
=======================================
Hits 10163 10163
Misses 2425 2425
Partials 823 823 ☔ View full report in Codecov by Sentry. |
/lgtm |
bf2499d
to
9197efa
Compare
9197efa
to
832e0a3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Changes
Align with rest of components reusing K8s.io codegen tooling.
Reference
Fixes #
Release Note