Supports setting comma separated env vars

[navidshaikh]

/lint

Proposed Changes

--env ENV1=VAL1 --env ENV2=VAL2,ENV3=VAL3

should work specifying by separate --env or specifying comma separated
values to --env or combination of both.

Release Note

Supports specifying comma separated environment variables as `--env KEY1=VAL1,KEY2=VAL2`

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@navidshaikh: 0 warnings.

In response to this:

/lint

Proposed Changes

--env ENV1=VAL1 --env ENV2=VAL2,ENV3=VAL3

should work specifying by separate --env or specifying comma separated
values to --env or combination of both.

Release Note

Supports specifying comma separated environment variables as `--env KEY1=VAL1,KEY2=VAL2`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

Fine with me, but please note that this might conflict with #342 which also has some minor tweaks on env vars. Maybe we can hold off with this one until #342 is merged ? (its soonish)

[rhuss]

@navidshaikh don't forget to add to CHANGELOG.adoc, too

[navidshaikh]

this might conflict with #342

@rhuss : I thought about that, separating the values by comma for --env should be handled by cobra and we receive the values in list before we interpret the values as mentioned #342.

Without comma

--env KEY=value sets EnvVar{Name: "KEY", Value: "value"} (current behavior)
--env KEY= sets EnvVar{Name: "KEY"} (current behavior)
--env KEY
--env KEY- removes the env var matching EnvVar{Name: "KEY", ...}

With comma

--env KEY=value,KEY2=value2
--env KEY=,KEY2=
--env KEY,KEY2
--env KEY-,KEY2-

I think this should just work fine without any additional processing.

[duglin]

No strong opinion either way, but do people have a guess as to how often someone may use a comma in an env var? Is there a way to escape it via cobra?

[knative-prow-robot]

@navidshaikh: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-client-integration-tests	b059f4d	link	/test pull-knative-client-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[navidshaikh]

but do people have a guess as to how often someone may use a comma in an env var? Is there a way to escape it via cobra?

Supporting this would disallow users from setting commas in env var values, need to check about escaping but single/double quotes on only values or even whole pair, back/forward slash didnt work.

➜  client git:(pr/multiple-envs)  ./kn service update svc --env TARGET="hello2,"
--env argument requires a value that contains the '=' character; got 

➜  client git:(pr/multiple-envs)  ./kn service update svc --env TARGET='hello2,'
--env argument requires a value that contains the '=' character; got 

➜  client git:(pr/multiple-envs)  ./kn service update svc --env TARGET=hello2\,  
--env argument requires a value that contains the '=' character; got 

➜  client git:(pr/multiple-envs)  ./kn service update svc --env TARGET=hello2/,
--env argument requires a value that contains the '=' character; got 

➜  client git:(pr/multiple-envs)  ./kn service update svc --env "TARGET=hello2,"
--env argument requires a value that contains the '=' character; got 

# the current behavior allows commas
➜  client git:(pr/multiple-envs)  git checkout master                           
➜  client git:(master)  go run ./cmd/kn/main.go service update svc --env TARGET=hello, 
Waiting for service 'svc' to become ready ... OK
Service 'svc' updated in namespace 'default'.

➜  client git:(master)  curl http://svc.default.apps-crc.testing                      
Hello hello,!

The current forma though support it (check last service update command above).

[duglin]

I did some digging and found this:
https://github.com/spf13/pflag/pull/59/files

And this does seem to work:

./kn service update echo --env=\"abc=def,def=qwe\"

So if we document this then I think we're good

[duglin]

We should add a test for it too :-)

[navidshaikh]

@duglin : Nice! I can do this as well

kn service update svc --env \"TARGET=hello,=\",TARGET=overwrite

[sixolet]

Add test for quoting (to have a comma in an env var), and for repeating the flag, to make sure we cover all the bases.

[jimcurtis]

LGTM

[navidshaikh]

repeat --env flag to specify multiple env vars, escaping might create more confusion.