Always create in new format rather than old #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/M
|
SGTM |
knative-prow-robot
added
size/L
|
/retest |
sixolet
force-pushed
the
creation-new-format
branch
from
cfa077a
to
afa1de8
Compare
|
The following is the coverage report on pkg/.
|
navidshaikh
approved these changes
Aug 15, 2019
| @@ -75,7 +75,7 @@ func TestServiceCreateLabel(t *testing.T) { | |||
| template.Spec.Containers[0].Image = "gcr.io/foo/bar:baz" | |||
| r.CreateService(service, nil) | |||
|
|
|||
| output, err := executeServiceCommand(client, "create", "foo", "--image", "gcr.io/foo/bar:baz", "-l", "a=mouse", "--label", "b=cookie", "--label=empty", "--async") | |||
| output, err := executeServiceCommand(client, "create", "foo", "--image", "gcr.io/foo/bar:baz", "-l", "a=mouse", "--label", "b=cookie", "--label=empty", "--async", "--revision-name=") | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
This gives us go 1.11. npm installation had to be tweaked up a bit with the new base image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version of the pull request where we don't make a flag to determine whether we want to use the "old format" or the "new lemonadey v1beta1 format", we just create new services in the new format.
This will DROP SUPPORT for 0.5
We could also have a flag, but this PR is quicker and easier to make, so I'm making it and we can discuss.