-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade spf13/cobra dep to current master #944
Upgrade spf13/cobra dep to current master #944
Conversation
which includes the zsh completion fix for spf13/cobra#899 and remove the fork of cobra with fix in `replace` section of go.mod
Do not define and execute extractCommand before running actual root command to parse all the args without flags. This was creating issues with completion utils to generate additional shell completion directive. Now uses cobra's inbuilt utilities to parse the command args without flags.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. It's questionable if tests for main.go
is needed... so do what you can.
Thanks for keeping us up to date with latest Cobra. Best.
The following is the coverage report on the affected files.
|
/retest
|
OK thanks. /lgtm |
Description
Pin cobra at v1.0.1-0.20200715031239-b95db644ed1c
Parse args without invoking a separate command
Do not define and execute extractCommand before running actual root
command to parse all the args without flags. This was creating issues
with completion utils to generate additional shell completion directive.
Now uses cobra's inbuilt utilities to parse the command args without flags.