Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of codecov for Knative repos #281

Closed
mattmoor opened this issue Sep 17, 2020 · 12 comments
Closed

Enable use of codecov for Knative repos #281

mattmoor opened this issue Sep 17, 2020 · 12 comments
Assignees
@mattmoor

Comments

@mattmoor
Copy link
Member

There is a nice (and free for OSS) code coverage tool, which a number of other projects I work with use (ggcr, ko, contour): codecov.io.

You can see a sample report here: google/go-containerregistry#770 (comment)

The configuration itself is relatively simple: https://github.com/google/go-containerregistry/blob/master/.codecov.yml

and it is pretty easy to integrate into common CI tools:

/assign
cc @n3wscott
@mattmoor
Copy link
Member Author

Oh, and when I looked into the permissions needed in order to install the Github application, they looked about as I'd have expected (IIRC the only "write" permission was commitstatus).

@n3wscott
Copy link
Contributor

Let me bootstrap on discovery and see if I run into issues.

@mattmoor
Copy link
Member Author

Well, we need to install the github app first 😉

@n3wscott
Copy link
Contributor

ok staged. knative-extensions/discovery#60

@n3wscott
Copy link
Contributor

looks like my job worked, but it does not yet have the full integration, https://codecov.io/github/knative-sandbox/discovery/commit/764f22331a5e37c9f54c23a7134597757085bca2

@mattmoor
Copy link
Member Author

Yeah, to write commit status it probably needs to be installed in the Github Org

@mattmoor
Copy link
Member Author

Here are the permissions it wants:

image

This seems about right for presubmit checks.

@mattmoor
Copy link
Member Author

I am going to grant it access to just discovery as we experiment with it.

@mattmoor
Copy link
Member Author

Alright, it works great on discovery, so I'm going to expand access to sandbox.

@mattmoor
Copy link
Member Author

You can see this in action here: knative-extensions/discovery#63 (comment)

@mattmoor
Copy link
Member Author

Scotty sent: knative-extensions/.github#20

This is done in the same style as Markus did golangci-lint, so if the config is present it runs. We'll pilot on a few sandbox repos first.

@mattmoor
Copy link
Member Author

This is done

@chizhg chizhg mentioned this issue Nov 24, 2020
Merged
daisy-ycguo pushed a commit to daisy-ycguo/community that referenced this issue Mar 12, 2021
Remove conflicting CoC (knative#281)
1c80f24 
In istio/community@d43a2d6#diff-6a3371457528722a734f3c51d9238c13R31, a different code of conduct was adopted within
the Istio community.

VALUES.md is referenced from `CONTRIBUTING.md` and `TECH-OVERSIGHT-COMMITTEE.md` which
both place the CoC first.

As such, this conflicting code of conduct may be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattmoor mattmoor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @n3wscott