Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken formatting in Installing guide #4917

Merged
merged 6 commits into from
Apr 15, 2022
Merged

Fix broken formatting in Installing guide #4917

merged 6 commits into from
Apr 15, 2022

Conversation

Subhasish-Behera
Copy link
Contributor

fixes #4477

@Subhasish-Behera
Task1 done
4a5302c 
“Installing Istio without sidecar injection(Recommended default installation)” added a space before the opening parenthesis.
@Subhasish-Behera
Task 2
3bddab5 
Correct formatting uses the opening tip tag (!!! tip), followed by a new line, and then 4 spaces before the tip text.
@Subhasish-Behera
Task 4
87a55fb 
 Task fixed: https://knative.dev/docs/install/uninstall/#uninstalling-optional-serving-extensions Broken numbering in the "TLS with cert-manager" tab. To fix, check for the correct indentation of the code snippet (8 spaces).
@Subhasish-Behera
Task 5
f519b5f 
Task fixed:  https://knative.dev/docs/install/uninstall/#uninstalling-optional-eventing-extensions broken numbering in Apace Kafka sink tab. To fix, check for the correct indentation of the code snippet (8 spaces).
@Subhasish-Behera
Task 3
62adc0a 
Task fixed:  https://knative.dev/docs/install/upgrade/upgrade-installation-with-operator/#rollback-to-an-earlier-version tab formatting is broken. To fix, indent the lines 126-146 and 150-170 by an extra 4 spaces.
@netlify
Copy link

netlify bot commented Apr 9, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 82fb3d1
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6255816b03917e00094c7915
😎 Deploy Preview https://deploy-preview-4917--knative.netlify.app/docs/install/installing-istio
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 9, 2022

Hi @Subhasish-Behera. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@snneji
Copy link
Contributor

snneji commented Apr 12, 2022

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
snneji
snneji suggested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@snneji snneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small tweak. Other than that it looks great. Thanks!

docs/install/installing-istio.md Outdated Show resolved Hide resolved
@Subhasish-Behera @snneji
changed the spacing according to the suggestion
82fb3d1 
Co-authored-by: Samia Nneji <snneji@vmware.com>
@Subhasish-Behera
Copy link
Contributor Author

done

@snneji
Copy link
Contributor

snneji commented Apr 15, 2022

Thanks for doing this one @Subhasish-Behera. 🙂

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snneji, Subhasish-Behera

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2022
@knative-prow knative-prow bot merged commit a1dcbc6 into knative:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snneji snneji snneji requested changes

Assignees

@snneji snneji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken formatting in Installing guide
2 participants
@Subhasish-Behera @snneji