Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SubscriptionsAPI filters to APIServerSource #5916

Merged
merged 2 commits into from
May 13, 2024
Merged

Add SubscriptionsAPI filters to APIServerSource #5916

merged 2 commits into from
May 13, 2024

Conversation

rh-hemartin
Copy link
Contributor

@rh-hemartin rh-hemartin commented Mar 19, 2024 •
edited
Loading

This MR adds a page for the experimental feature that add filters to the APIServerSource kind.

Related to #7799 and #7791

Proposed Changes

  • Add a page for the experimental feature that adds filters to APIServerSource

@rh-hemartin
Add SubscriptionsAPI filters to APIServerSource
3bdd444 
This MR adds a page for the experimental feature that
add `filters` to the APIServerSource kind.

Related to #7799 and #7791

Signed-off-by: Hector Martinez <hemartin@redhat.com>
@knative-prow knative-prow bot requested review from pierDipi and skonto March 19, 2024 11:19
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 19, 2024

Welcome @rh-hemartin! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f67f033
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/663b72689b5898000844b402
😎 Deploy Preview https://deploy-preview-5916--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rh-hemartin rh-hemartin mentioned this pull request Mar 19, 2024
Merged
5 tasks
@pierDipi
Copy link
Member

pierDipi commented May 8, 2024

thanks @rh-hemartin, just one comment since we changed it to alpha and disabled

@rh-hemartin @pierDipi
MR suggestion
f67f033 
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@rh-hemartin
Copy link
Contributor Author

thanks @rh-hemartin, just one comment since we changed it to alpha and disabled

Thanks for the suggestion, I applied it. This should be squashed when merged?

pierDipi
pierDipi approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

The bot will do that for us

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@pierDipi pierDipi mentioned this pull request May 13, 2024
Open
Cali0707
Cali0707 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@knative-prow knative-prow bot merged commit 84776e2 into knative:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@pierDipi pierDipi pierDipi approved these changes

@skonto skonto Awaiting requested review from skonto

Assignees

@pierDipi pierDipi

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rh-hemartin @pierDipi @Cali0707