Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the documentation for the default broker class feature #6069

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the documentation for the default broker class feature #6069

wants to merge 2 commits into from

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Jul 22, 2024

Proposed Changes

@knative-prow knative-prow bot requested review from pierDipi and ReToCode July 22, 2024 16:18
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d25fe84
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/669e9c51c4fa1d00083fdb8f
😎 Deploy Preview https://deploy-preview-6069--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leo6Leo Leo6Leo changed the title Add the documentation for the default broker class feature [WIP] Add the documentation for the default broker class feature Jul 22, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@Leo6Leo Leo6Leo changed the title [WIP] Add the documentation for the default broker class feature Add the documentation for the default broker class feature Jul 22, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Jul 22, 2024

/hold until the broker config PR mentioned in the description get merged.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2024
@Leo6Leo Leo6Leo mentioned this pull request Jul 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi Awaiting requested review from pierDipi

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Leo6Leo