-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting domain name in Getting Started with Knative App Deployment #993
Conversation
Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change. Environment GKE 1.11.7-gke.4, Knative 0.4.0
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks @miosman ! This looks good, but can you resolve the conflicts? |
@samodell I've fixed the conflict and update the second instance where ksvc is used to get the domain for consistency. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: miosman, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative#993) * Fixed getting domain name Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change. Environment GKE 1.11.7-gke.4, Knative 0.4.0 * updated HOST_URL script to use route
* Fix getting domain name in Getting Started with Knative App Deployment (#993) * Fixed getting domain name Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change. Environment GKE 1.11.7-gke.4, Knative 0.4.0 * updated HOST_URL script to use route * move shell sample over to docs (#1085) * add website files for shell sample (#1087) * Update build/auth documentation to document kubernetes.io/* secrets (#1098) Since v0.4.0 release, knative/build supports additional secrets for docker registries : `kubernetes.io/dockerconfigjson` and `kubernetes/dockercfg`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com> * Add KafkaSource information and link to example (#1099) * fix typo Quele -> Queue (#1100) * fixes #1109 * build: code block was smooshed (#1124) the code block formating got smooshed into the paragraph above Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.
Environment GKE 1.11.7-gke.4, Knative 0.4.0
Fixes #297
Proposed Changes