Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting domain name in Getting Started with Knative App Deployment #993

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Conversation

miosman
Copy link
Contributor

@miosman miosman commented Mar 13, 2019

Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.

Environment GKE 1.11.7-gke.4, Knative 0.4.0

Fixes #297

Proposed Changes

Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.

Environment GKE 1.11.7-gke.4, Knative 0.4.0
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Mar 13, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2019
@miosman
Copy link
Contributor Author

miosman commented Mar 13, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Mar 13, 2019
@miosman miosman marked this pull request as ready for review March 13, 2019 07:55
@miosman miosman changed the title Fixed getting domain name Fix getting domain name in Getting Started with Knative App Deployment Mar 13, 2019
@samodell
Copy link
Contributor

Thanks @miosman ! This looks good, but can you resolve the conflicts?

@miosman
Copy link
Contributor Author

miosman commented Mar 22, 2019

@samodell I've fixed the conflict and update the second instance where ksvc is used to get the domain for consistency.

@sebgoa
Copy link
Contributor

sebgoa commented Mar 22, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2019
@samodell
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miosman, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2fdc4bb into knative:master Mar 25, 2019
samodell pushed a commit to samodell/docs that referenced this pull request Apr 2, 2019
knative#993)

* Fixed getting domain name

Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.

Environment GKE 1.11.7-gke.4, Knative 0.4.0

* updated HOST_URL script to use route
knative-prow-robot pushed a commit that referenced this pull request Apr 2, 2019
* Fix getting domain name in Getting Started with Knative App Deployment (#993)

* Fixed getting domain name

Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.

Environment GKE 1.11.7-gke.4, Knative 0.4.0

* updated HOST_URL script to use route

* move shell sample over to docs (#1085)

* add website files for shell sample (#1087)

* Update build/auth documentation to document kubernetes.io/* secrets (#1098)

Since v0.4.0 release, knative/build supports additional secrets for
docker registries : `kubernetes.io/dockerconfigjson` and
`kubernetes/dockercfg`.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

* Add KafkaSource information and link to example (#1099)

* fix typo Quele -> Queue (#1100)

* fixes #1109

* build: code block was smooshed (#1124)

the code block formating got smooshed into the paragraph above

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants