-
Notifications
You must be signed in to change notification settings - Fork 225
Port KafkaChannel to new bindings API #1039
Port KafkaChannel to new bindings API #1039
Conversation
cool, I will run some tests here |
/hold I wish to fix the intermediate buffering that happens inside message receiver, which can be avoided for the kafka case |
Depends on knative/eventing#2773 |
5cb6157
to
6880d14
Compare
/unhold |
/assign |
Outside of those two nits this works for me |
/unhold |
@slinkydeveloper did you test these changes? With the last commit the dispatcher doesn't forward any messages anymore for me. Seems like the correct approach (for now) is to keep the variables assigned below the |
Funny how the test pass... |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
364660f
to
68efce1
Compare
The following is the coverage report on the affected files.
|
@lberk I've tested locally and it works :) |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lberk, n3wscott, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #976