Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

fix github webhook rbac rules #1057

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

lionelvillard
Copy link
Member

Fixes #1048

Proposed Changes

  • Add missing RBAC rules for registering the webhook.

Release Note


Docs

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 24, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Apr 1, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit fd2dbb8 into knative:master Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHubSource: Missing RBAC rules for mutating & validating webhook configurations
4 participants