Remove finalizer to avoid finalize loop in GitHubSource FinalizeKind().

[tom24d]

Fixes #1058

Proposed Changes

-🐛return EventTypeNormal to remove finalizer when Secret is not found instead of plain err.
-🐛return EventTypeNormal to remove finalizer when 404 is returned instead of plain err.
-🧽change the event message to describe the behavior.

[knative-prow-robot]

Hi @tom24d. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lionelvillard]

/ok-to-test

[lionelvillard]

/lgtm

[lberk]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, tom24d

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• github/pkg/reconciler/OWNERS [lberk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment