Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Removed default content type in kafkasource #1117

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Removed default content type in kafkasource #1117

merged 2 commits into from
Apr 8, 2020

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Apr 8, 2020 •
edited
Loading

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #1050

Release Notes

Now KafkaSource won't emit anymore events with `datacontenttype` equal to `application/json` if the message was a non event and it was missing a `content-type`

@slinkydeveloper
Fix knative#1050
da8c771 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 8, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2020
@slinkydeveloper slinkydeveloper changed the title Fix #1050 Removed default content type in kafkasource Apr 8, 2020
@slinkydeveloper
Copy link
Contributor Author

/assign @matzew

@slinkydeveloper
Fixed e2e test
310548b 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/adapter/message.go 79.7% 78.8% -0.9

@lberk
Copy link
Member

lberk commented Apr 8, 2020

/assign

@lberk
Copy link
Member

lberk commented Apr 8, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@lionelvillard
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@knative-prow-robot knative-prow-robot merged commit 511cc24 into knative:master Apr 8, 2020
@slinkydeveloper slinkydeveloper deleted the fix/1050 branch May 7, 2020 14:02
This was referenced May 19, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lberk lberk Awaiting requested review from lberk

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

@lberk lberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka source silently drops events if they're not JSON
7 participants
@slinkydeveloper @knative-metrics-robot @lberk @lionelvillard @knative-prow-robot @matzew @googlebot