Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Kafkasource v1beta1 reconciler #1405

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Kafkasource v1beta1 reconciler #1405

merged 2 commits into from
Jul 27, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Jul 23, 2020 •
edited

Fixes #1395

Proposed Changes

  • Use KafkaSource and KafkaBinding v1beta1 in reconciler
  • Change condition KeyResourcesCorrect to KeyTypeCorrect as it resources don't exist in spec anymore and key type lifecycle checks was using KeyResourcesCorrect mistakenly

Release Note

- 🧽 Update or clean up current behavior
Reconcile KafkaSource and KafkaBinding using v1beta1 api shape. Operate on dependent resources (Subscriptions, etc.) using their v1 shapes. Note that `resource` and `serviceAccountName` fields are removed from the types in v1beta1.

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 23, 2020
@knative-prow-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2020
aliok
aliok commented Jul 23, 2020
View reviewed changes
kafka/source/pkg/reconciler/source/controller.go
kafkainformer "knative.dev/eventing-contrib/kafka/source/pkg/client/injection/informers/sources/v1alpha1/kafkasource"
"knative.dev/eventing-contrib/kafka/source/pkg/client/injection/reconciler/sources/v1alpha1/kafkasource"
kafkainformer "knative.dev/eventing-contrib/kafka/source/pkg/client/injection/informers/sources/v1beta1/kafkasource"
"knative.dev/eventing-contrib/kafka/source/pkg/client/injection/reconciler/sources/v1beta1/kafkasource"
)

func NewController(
Copy link
Member Author

@aliok aliok Jul 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use "knative.dev/eventing/pkg/apis/sources/v1alpha1" yet as it is not released yet.

https://github.com/knative/eventing-contrib/pull/1405/files/c0c3836dffd61e5b8c4854652ff5070097936021#diff-b066322f3ce3923fc969c101ce068b9fR25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's a blocker for this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps go w/ "latest" of the dependency ? (aka master branch)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to learn more about Go modules :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me do this later. Nothing unique from that package is used anyway. Only a Kind function which is identical in v1alpha1.
When the dependency to eventing is changed to master I can do it.

@aliok aliok changed the title [WIP] Kafkasource v1beta1 reconciler Kafkasource v1beta1 reconciler Jul 24, 2020
@aliok
Copy link
Member Author

aliok commented Jul 24, 2020

/retest

@aliok aliok marked this pull request as ready for review July 24, 2020 06:30
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2020
@aliok
Copy link
Member Author

aliok commented Jul 24, 2020

ready for review
cc @matzew @lionelvillard @vaikas

About the comment in #1405 (comment) : let's do that part later

@vaikas
Copy link
Contributor

vaikas commented Jul 24, 2020

/lgtm
/hold
for others to chime in. Also, might want to mention that the resource spec does not exist in the release notes?

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@aliok
Copy link
Member Author

aliok commented Jul 27, 2020

Also, might want to mention that the resource spec does not exist in the release notes?

Updated the PR desc. all good

matzew
matzew approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@knative-prow-robot knative-prow-robot merged commit f1f0b1e into knative:master Jul 27, 2020
@aliok aliok deleted the kafkasource-v1beta1-reconciler branch July 27, 2020 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew approved these changes

@lberk lberk Awaiting requested review from lberk

Assignees

@matzew matzew

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make reconcilers use KafkaSource and KafkaBinding v1beta1 resources
5 participants
@aliok @knative-prow-robot @vaikas @matzew @googlebot