Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Kafka Channel retries sending events #1409

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Kafka Channel retries sending events #1409

merged 1 commit into from
Jul 29, 2020

Conversation

pierDipi
Copy link
Member

Fixes #753
Fixes #933

Proposed Changes

  • Kafka Channel retries sending events

Release Note

- 🎁 Add new feature
Kafka Channel retries sending events

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 27, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release labels Jul 27, 2020
@pierDipi
Copy link
Member Author

it's based on #1408

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
natss/pkg/reconciler/dispatcher/natsschannel.go 84.1% 80.3% -3.8

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2020
@pierDipi pierDipi changed the title [WIP] Kafka Channel retries sending events Kafka Channel retries sending events Jul 29, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020
@pierDipi
Copy link
Member Author

/assign @slinkydeveloper

@pierDipi
Kafka Channel retries sending events
f424b23 
- Add retry support to KafkaChannel
- Add e2e test for Broker redelivery backed by KafkaChannel

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Copy link
Member Author

It works locally, retesting

/retest

@pierDipi
Copy link
Member Author

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

matzew
matzew approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@slinkydeveloper
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot merged commit 6443bff into knative:master Jul 29, 2020
@lionelvillard
Copy link
Member

@pierDipi Thanks for doing this! This is great!

Can you open a documentation issue? We should update this page: https://knative.dev/development/eventing/event-delivery/

@pierDipi
Copy link
Member Author

@lionelvillard Done!
knative/docs#2712

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@coryrc coryrc Awaiting requested review from coryrc

@devguyio devguyio Awaiting requested review from devguyio

@lberk lberk Awaiting requested review from lberk

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@nachocano nachocano Awaiting requested review from nachocano

@rootfs rootfs Awaiting requested review from rootfs

@sebgoa sebgoa Awaiting requested review from sebgoa

@syedriko syedriko Awaiting requested review from syedriko

Assignees

@matzew matzew

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E test for Kafka Channel redelivery Kafka should retry sending events
7 participants
@pierDipi @knative-metrics-robot @knative-prow-robot @slinkydeveloper @lionelvillard @matzew @googlebot