Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Drop AWSSQS Source #1576

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Drop AWSSQS Source #1576

merged 1 commit into from
Sep 18, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Sep 16, 2020

AWSSQS source has moved to https://github.com/knative-sandbox/eventing-awssqs
Related: #1482 1482

Proposed Changes

  • Drop AWS SQS Source from eventing-contrib and moving to knative-sandbox

Release Note

The AWSSQS source artifacts have moved to https://github.com/knative-sandbox/eventing-awssqs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 16, 2020
@lberk
Copy link
Member Author

lberk commented Sep 16, 2020

/hold
verify that the nightly release for sandbox has shipped before we actually drop this from eventing-contrib

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2020
@matzew
Copy link
Member

matzew commented Sep 16, 2020

/retest

@lberk
Copy link
Member Author

lberk commented Sep 16, 2020

adding eventing-awssqs test-infra: knative/test-infra#2432

@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@lberk
Copy link
Member Author

lberk commented Sep 18, 2020

nightlies are green in testgrid
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@knative-prow-robot knative-prow-robot merged commit 19db1ab into knative:master Sep 18, 2020
@runzexia runzexia mentioned this pull request Oct 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lberk @knative-prow-robot @matzew @lionelvillard @googlebot