Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

remove couchdb #1583

Merged
merged 2 commits into from
Sep 18, 2020
Merged

remove couchdb #1583

merged 2 commits into from
Sep 18, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Sep 16, 2020 •
edited

Proposed Changes

Release Note

The CouchDB source artifacts have moved to https://github.com/knative-sandbox/eventing-couchdb

Docs

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 16, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 16, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release labels Sep 16, 2020
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-contrib-integration-tests
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@pierDipi
Copy link
Member

Please, update release notes.

@lionelvillard
Copy link
Member Author

@pierDipi done. thanks!

pierDipi
pierDipi approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Do we need to wait for a successful nightly release? https://testgrid.knative.dev/eventing-couchdb#nightly&width=20

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@lionelvillard
Copy link
Member Author

nightly is green. https://testgrid.knative.dev/eventing-couchdb#nightly

/unhold

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 18, 2020
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 18, 2020
aliok
aliok approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

🔥

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member 

/home/prow/go/src/knative.dev/eventing-contrib/hack/update-codegen.sh: line 143: syntax error near unexpected token `<<<'

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@lionelvillard
Copy link
Member Author

@aliok @pierDipi finally good to go!

@pierDipi
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@knative-prow-robot knative-prow-robot merged commit 5093881 into knative:master Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aliok aliok aliok approved these changes

@pierDipi pierDipi pierDipi approved these changes

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@aliok aliok

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lionelvillard @pierDipi @knative-prow-robot @aliok @googlebot