Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Adding standard duck label on CRD to signal this resource adheres to Addressable #676

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Adding standard duck label on CRD to signal this resource adheres to Addressable #676

merged 1 commit into from
Oct 25, 2019

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Oct 25, 2019 •
edited
Loading

Proposed Changes

  • Label Kakfa and NATS channel CRDs with duck.knative.dev/addressable: "true".

Release Note

Kakfa and NATS channel CRDs are now labeled with duck.knative.dev/addressable: "true".

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 25, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
mattmoor
mattmoor reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@knative-prow-robot knative-prow-robot merged commit 28bee5b into knative:master Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattmoor mattmoor mattmoor left review comments

@devguyio devguyio Awaiting requested review from devguyio

@matzew matzew Awaiting requested review from matzew

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n3wscott @knative-prow-robot @mattmoor @googlebot