Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Add Ready column to GithubSource #713

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Add Ready column to GithubSource #713

merged 1 commit into from
Nov 7, 2019
+7 −0

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Nov 7, 2019

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 7, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
mattmoor-sockpuppet
mattmoor-sockpuppet reviewed Nov 7, 2019
View reviewed changes
Copy link
Contributor

@mattmoor-sockpuppet mattmoor-sockpuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found go linting violations, please merge: mattmoor#2

@mattmoor
Copy link
Member Author

mattmoor commented Nov 7, 2019

/retest

cc @chaodaiG

Harwayne
Harwayne reviewed Nov 7, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@matzew
Copy link
Member

matzew commented Nov 7, 2019

@mattmoor @Harwayne @grantr IMO its a huge problem that almost every CI run has memory issues :-(

@chizhg mentioned that for serving some resource improvements where done ?! to have better machine ?

@matzew
Copy link
Member

matzew commented Nov 7, 2019

/test pull-knative-eventing-contrib-build-tests

@chizhg
Copy link
Member

chizhg commented Nov 7, 2019 •
edited
Loading

@mattmoor @Harwayne @grantr IMO its a huge problem that almost every CI run has memory issues :-(

@chizhg mentioned that for serving some resource improvements where done ?! to have better machine ?

I have already increased the resource requests for the build test jobs. Hopefully the issue can be solved :)

@matzew
Copy link
Member

matzew commented Nov 7, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@knative-prow-robot knative-prow-robot merged commit 7518a4d into knative:master Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Harwayne Harwayne Harwayne left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@n3wscott n3wscott Awaiting requested review from n3wscott

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@grantr grantr

@matzew matzew

@Harwayne Harwayne

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mattmoor @matzew @chizhg @knative-prow-robot @Harwayne @mattmoor-sockpuppet @grantr @googlebot @n3wscott