NatssChannel Dispatcher: prioritize finalizer removal

[nachtmaar]

Proposed Changes

• Remove natsschannel finalizer as early as possible

• Add simple test to validate that finalizer on natsschannel gets removed even though natss channel is not ready

• Add NatssDispatcher interface

• removed unreferenced toSubscriberStatus function

• add typedef SubscriptionChannelMapping

• Bumped code coverage to 83 % ( I din't see that code coverage job is optional :/ )

Release Note

Fix that natsschannel finalizer doesn't get removed

See also kyma-project/kyma#6792

[knative-prow-robot]

Hi @nachtmaar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nachtmaar]

/assign @Abd4llA

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[devguyio]

/ok-to-test

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[antoineco]

Only minor comments, good job!

[antoineco]

/lgtm

[nachtmaar]

/test pull-knative-eventing-contrib-integration-tests

[k15r]

/lgtm

[knative-prow-robot]

@k15r: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
natss/pkg/reconciler/dispatcher/natsschannel.go	Do not exist	83.3%

[nachtmaar]

/test pull-knative-eventing-contrib-integration-tests

[k15r]

/lgtm

[knative-prow-robot]

@k15r: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[antoineco]

/lgtm

[devguyio]

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, k15r, nachtmaar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• natss/OWNERS [Abd4llA]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment