Now KafkaSource supports cloudevents Kafka Structured Encoding #884
Conversation
https://github.com/cloudevents/spec/blob/v1.0/kafka-protocol-binding.md#33-structured-content-mode) Fixed bad extension name when dumping kafka headers to event extensions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/L
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
| @@ -172,7 +172,7 @@ function kafka_setup() { | |||
| sed 's/namespace: .*/namespace: kafka/' ${STRIMZI_INSTALLATION_CONFIG_TEMPLATE} > ${STRIMZI_INSTALLATION_CONFIG} | |||
| kubectl apply -f "${STRIMZI_INSTALLATION_CONFIG}" -n kafka | |||
| kubectl apply -f ${KAFKA_INSTALLATION_CONFIG} -n kafka | |||
| kubectl apply -f ${KAFKA_TOPIC_INSTALLATION_CONFIG} -n kafka | |||
| # kubectl apply -f ${KAFKA_TOPIC_INSTALLATION_CONFIG} -n kafka | |||
There was a problem hiding this comment.
It's deliberate: it's not needed anymore for running the tests but i wish to leave it for anybody who needs a quick test topic
There was a problem hiding this comment.
I'm not sure somebody will be looking at knative e2e testing for basic strimzi configuration setup?
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
Release notes followup: This was a new feature and should have had a release note blurb 😃 |
|
@grantr I'm sorry, should i add it directly here in the PR description? |
|
@slinkydeveloper for future PRs, use the release note block in the PR template when making a user-visible change (the template has instructions). If everyone does that, we can auto-generate the release notes instead of waiting for a human to spend hours copying and pasting :) |
Following spec: https://github.com/cloudevents/spec/blob/v1.0/kafka-protocol-binding.md#33-structured-content-mode
Also fixed bad extension name when dumping kafka headers to event extensions
Fixes #842