This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
diff the dispatcher.Spec and update as necessary #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
matzew
reviewed
Feb 12, 2020
| Brokers: []string{brokerName}, | ||
| }, | ||
| kafkachannelLister: listers.GetKafkaChannelLister(), | ||
| // TODO fix |
There was a problem hiding this comment.
lol :) Copy and paste from an existing test, so not sure what the actual TODO fix is :)
But, sure I'll create an issue :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you deploy new Kafka controller and an accompanying different Dispatcher (aka, different image), the dispatcher is never updated and the old dispatcher will keep on running and not picking up the new image.
Proposed Changes
Release Note