contrib/kafka: support cert, key, and caCert in spec.net.tls

[danp]

Proposed Changes

• Add cert, key, and caCert attributes to KafkaSource's spec.net.tls object
• Support these new attributes when spec.net.tls.enable is true

Release Note

KafkaSource now supports configuring client certificate and key and server CA cert via new `spec.net.tls.cert`, `spec.net.tls.key`, and `spec.net.tls.caCert` attributes.

[knative-prow-robot]

Hi @danp. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

/ok-to-test

[matzew]

can you look at the tests?

On Fri 10. May 2019 at 16:19, covbot ***@***.***> wrote: The following is the coverage report on pkg/. Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report File Old Coverage New Coverage Delta contrib/kafka/pkg/adapter/adapter.go <https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_eventing-sources/407/pull-knative-eventing-sources-go-coverage/1126853364634619907/artifacts/line-cov.html#file0> 14.5% 8.8% -5.8 contrib/kafka/pkg/reconciler/resources/receive_adapter.go <https://storage.cloud.google.com/knative-prow/pr-logs/pull/knative_eventing-sources/407/pull-knative-eventing-sources-go-coverage/1126853364634619907/artifacts/line-cov.html#file2> 100.0% 91.7% -8.3 — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABGPTULEDUBH27SFSEM4I3PUWAARANCNFSM4HMDCZHQ> .

-- Sent from Gmail Mobile

[danp]

Added tests for newTLSConfig and verifyCertSkipHostname in pkg/adapter which helped coverage there.

[danp]

And went ahead and added another test to pkg/reconciler/resources which should get that back to 100%.

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
contrib/kafka/pkg/adapter/adapter.go	14.5%	37.4%	22.8

[matzew]

👍

[matzew]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danp, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• contrib/kafka/OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment