Skip to content

fix: sequence updates subscription where possible, instead of recreating it #6299

fix: sequence updates subscription where possible, instead of recreating it

fix: sequence updates subscription where possible, instead of recreating it #6299

Triggered via pull request May 30, 2024 15:47
Status Failure
Total duration 3m 39s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
23s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 19s
style / Golang / Lint
style  /  ...  /  Do Not Submit
6s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
style / Golang / Auto-format and Check: pkg/apis/eventing/v1beta2/eventtype_conversion_test.go#L1
Please run goimports. diff --git a/pkg/apis/eventing/v1beta2/eventtype_conversion_test.go b/pkg/apis/eventing/v1beta2/eventtype_conversion_test.go index 6ad1c9e..058146f 100644 --- a/pkg/apis/eventing/v1beta2/eventtype_conversion_test.go +++ b/pkg/apis/eventing/v1beta2/eventtype_conversion_test.go @@ -42,11 +42,11 @@ func TestEventTypeConversionHighestVersion(t *testing.T) { func TestEventTypeConversionV1Beta3(t *testing.T) { in := &EventType{ - TypeMeta: metav1.TypeMeta{}, + TypeMeta: metav1.TypeMeta{}, ObjectMeta: metav1.ObjectMeta{ - Name: "my-name", - Namespace: "my-ns", - UID: "1234", + Name: "my-name", + Namespace: "my-ns", + UID: "1234", }, Spec: EventTypeSpec{ Type: "t1", @@ -68,11 +68,11 @@ func TestEventTypeConversionV1Beta3(t *testing.T) { } expected := &v1beta3.EventType{ - TypeMeta: metav1.TypeMeta{}, + TypeMeta: metav1.TypeMeta{}, ObjectMeta: metav1.ObjectMeta{ - Name: "my-name", - Namespace: "my-ns", - UID: "1234", + Name: "my-name", + Namespace: "my-ns", + UID: "1234", }, Spec: v1beta3.EventTypeSpec{ Reference: in.Spec.Reference.DeepCopy(),
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum