Broker class based defaults #6430
knative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
23s
style
/
...
/
Lint
3m 36s
style
/
...
/
Do Not Submit
7s
style
/
...
/
shell
0s
style
/
...
/
yaml
26s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
2 errors and 5 warnings
style / Golang / Auto-format and Check:
pkg/apis/config/defaults.go#L1
Please run goimports.
diff --git a/pkg/apis/config/defaults.go b/pkg/apis/config/defaults.go
index 51a39de..1ca836c 100644
--- a/pkg/apis/config/defaults.go
+++ b/pkg/apis/config/defaults.go
@@ -117,8 +117,8 @@ func (d *Defaults) GetBrokerConfig(ns string, brokerClassName *string) (*BrokerC
return d.getBrokerConfigForEmptyClassName(ns)
}
-// getBrokerConfigByClassName returns the BrokerConfig for the given brokerClassName.
-// It first checks the namespace specific configuration, then the cluster default configuration.
+// getBrokerConfigByClassName returns the BrokerConfig for the given brokerClassName.
+// It first checks the namespace specific configuration, then the cluster default configuration.
func (d *Defaults) getBrokerConfigByClassName(ns string, brokerClassName string) (*BrokerConfig, error) {
// Check namespace specific configuration
if nsConfig, ok := d.NamespaceDefaultsConfig[ns]; ok && nsConfig != nil {
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / suggester / yaml
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|