[WIP] ๐งน Removing the vendor dir #6574
knative-style.yaml
on: pull_request
style
/
changes
20s
style
/
...
/
Auto-format and Check
19s
style
/
...
/
Lint
3m 39s
style
/
...
/
Do Not Submit
13s
style
/
...
/
shell
24s
style
/
...
/
yaml
27s
style
/
...
/
github_actions
13s
Matrix: style / Golang / Boilerplate Check
Annotations
25 errors and 7 warnings
style / Golang / Lint:
DEVELOPMENT.md#L134
[trailing whitespace] reported by reviewdog ๐ถ
> :information_source: If you are getting the error `No resources found in cert-manager namespace`, you need to install [cert-manager](https://cert-manager.io/docs/installation/) manually before running the quick full build and install command.
Raw Output:
DEVELOPMENT.md:134:> :information_source: If you are getting the error `No resources found in cert-manager namespace`, you need to install [cert-manager](https://cert-manager.io/docs/installation/) manually before running the quick full build and install command.
|
style / Golang / Lint:
config/300-eventtype.yaml#L64
[trailing whitespace] reported by reviewdog ๐ถ
type: array
Raw Output:
config/300-eventtype.yaml:64: type: array
|
style / Golang / Lint:
config/400-config-features.yaml#L46
[trailing whitespace] reported by reviewdog ๐ถ
Raw Output:
config/400-config-features.yaml:46:
|
style / Golang / Lint:
config/core/configmaps/features.yaml#L46
[trailing whitespace] reported by reviewdog ๐ถ
Raw Output:
config/core/configmaps/features.yaml:46:
|
style / Golang / Lint:
config/core/resources/eventtype.yaml#L64
[trailing whitespace] reported by reviewdog ๐ถ
type: array
Raw Output:
config/core/resources/eventtype.yaml:64: type: array
|
style / Golang / Lint:
hack/run.sh#L1
[trailing whitespace] reported by reviewdog ๐ถ
#!/usr/bin/env bash
Raw Output:
hack/run.sh:1:#!/usr/bin/env bash
|
style / Golang / Lint:
hack/run.sh#L31
[trailing whitespace] reported by reviewdog ๐ถ
./"${ROOT_DIR}"/hack/install.sh
Raw Output:
hack/run.sh:31: ./"${ROOT_DIR}"/hack/install.sh
|
style / Golang / Lint:
hack/run.sh#L47
[trailing whitespace] reported by reviewdog ๐ถ
./"${ROOT_DIR}"/hack/update-deps.sh
Raw Output:
hack/run.sh:47: ./"${ROOT_DIR}"/hack/update-deps.sh
|
style / Golang / Lint:
pkg/kncloudevents/http_client.go#L85
createNewClient - result 1 (error) is always nil (unparam)
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L128
`NewController$3` - `obj` is unused (unparam)
|
style / Golang / Lint:
pkg/scheduler/statefulset/scheduler.go#L363
func `toJSONable` is unused (unused)
|
style / Golang / Lint:
pkg/reconciler/source/duck/duck.go#L45
const `defaultNamespace` is unused (unused)
|
style / Golang / Lint:
test/rekt/features/channel/helpers.go#L101
func `patchChannelable` is unused (unused)
|
style / Golang / Lint:
cmd/jobsink/main.go#L204
SA1019: h.oidcTokenVerifier.VerifyJWTFromRequest is deprecated: use OIDCTokenVerifier.Verify() instead to bundle AuthN and AuthZ verification (staticcheck)
|
style / Golang / Lint:
cmd/jobsink/main.go#L385
SA1019: h.oidcTokenVerifier.VerifyJWTFromRequest is deprecated: use OIDCTokenVerifier.Verify() instead to bundle AuthN and AuthZ verification (staticcheck)
|
style / Golang / Lint:
pkg/reconciler/sinkbinding/sinkbinding.go#L39
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
|
style / Golang / Lint:
test/lib/logexporter.go#L84
SA1019: prow.IsCI is deprecated: use knative.dev/pkg/test/ci.IsCI (staticcheck)
|
style / Golang / Lint:
test/lib/logexporter.go#L97
SA1019: prow.GetLocalArtifactsDir is deprecated: use knative.dev/pkg/test/ci.GetLocalArtifactsDir (staticcheck)
|
style / Golang / Lint:
DEVELOPMENT.md#L15
[github.com/client9/misspell] reported by reviewdog ๐ถ
"fullfilled" is a misspelling of "fulfilled"
Raw Output:
DEVELOPMENT.md:15:39: "fullfilled" is a misspelling of "fulfilled"
|
style / Golang / Lint:
DEVELOPMENT.md#L493
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
DEVELOPMENT.md:493: Missing newline
|
style / Golang / Lint:
docs/mt-channel-based-broker/mt-channel-broker.png#L1294
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/mt-channel-based-broker/mt-channel-broker.png:1294: Missing newline
|
style / Golang / Lint:
docs/planning/images/featureplanning.png#L32
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/planning/images/featureplanning.png:32: Missing newline
|
style / Golang / Lint:
docs/planning/images/releaseplanning.png#L75
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/planning/images/releaseplanning.png:75: Missing newline
|
style / Golang / Lint:
hack/run.sh#L54
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
hack/run.sh:54: Missing newline
|
style / Golang / Lint:
hack/teardown.sh#L34
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
hack/teardown.sh:34: Missing newline
|
style / suggester / github_actions
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / suggester / shell
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / suggester / yaml
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|