Fix possible nil pointer dereference in event-dispatcher (#7994)

* Fix possible nil pointer dereference in event-dispatcher * readErr -> err
knative · Jun 12, 2024 · 6259113 · 6259113
1 parent 67ceb9e
commit 6259113
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/kncloudevents/event_dispatcher.go b/pkg/kncloudevents/event_dispatcher.go
@@ -334,11 +334,11 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
 	dispatchInfo.ResponseHeader = response.Header
 
 	body := new(bytes.Buffer)
-	_, readErr := body.ReadFrom(response.Body)
+	_, err = body.ReadFrom(response.Body)
 
 	if isFailure(response.StatusCode) {
 		// Read response body into dispatchInfo for failures
-		if readErr != nil && readErr != io.EOF {
+		if err != nil && err != io.EOF {
 			dispatchInfo.ResponseBody = []byte(fmt.Sprintf("dispatch resulted in status \"%s\". Could not read response body: error: %s", response.Status, err.Error()))
 		} else {
 			dispatchInfo.ResponseBody = body.Bytes()
@@ -350,7 +350,7 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab
 	}
 
 	var responseMessageBody []byte
-	if readErr != nil && readErr != io.EOF {
+	if err != nil && err != io.EOF {
 		responseMessageBody = []byte(fmt.Sprintf("Failed to read response body: %s", err.Error()))
 	} else {
 		responseMessageBody = body.Bytes()