unit test bug fix

knative · Nov 22, 2022 · bdce2f4 · bdce2f4
1 parent 3ef5c30
commit bdce2f4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/pkg/apis/config/defaults_test.go b/pkg/apis/config/defaults_test.go
@@ -52,15 +52,15 @@ func TestGetBrokerConfig(t *testing.T) {
 	if c.Delivery.DeadLetterSink.Ref.Name != "mt-handle-error" {
 		t.Error("GetBrokerConfig Failed, wanted mt-handle-error, got:", c.Delivery.DeadLetterSink.Ref.Name)
 	}
-	c, err = defaults.GetBrokerConfig("some-namespace")
+	c, err = defaults.GetBrokerConfig("some-namespace-three")
 	if err != nil {
 		t.Error("GetBrokerConfig Failed =", err)
 	}
 	if c.Name != "someothername" {
 		t.Error("GetBrokerConfig Failed, wanted someothername, got:", c.Name)
 	}
 	// Test GetBrokerConfig in different namespace
-	c, err = defaults.GetBrokerConfig("some-namespace-two")
+	c, err = defaults.GetBrokerConfig("some-namespace")
 	if err != nil {
 		t.Error("GetBrokerConfig Failed =", err)
 	}
@@ -71,7 +71,7 @@ func TestGetBrokerConfig(t *testing.T) {
 		t.Error("GetBrokerConfig Failed, wanted kafka-handle-error, got:", c.Delivery.DeadLetterSink.Ref.Name)
 	}
 
-	c, err = defaults.GetBrokerConfig("some-namespace-three")
+	c, err = defaults.GetBrokerConfig("some-namespace-two")
 	if err != nil {
 		t.Error("GetBrokerConfig Failed =", err)
 	}
@@ -114,7 +114,7 @@ func TestGetBrokerClass(t *testing.T) {
 	if c != "MTChannelBasedBroker" {
 		t.Error("GetBrokerClass Failed, wanted MTChannelBasedBroker, got:", c)
 	}
-	c, err = defaults.GetBrokerClass("some-namespace")
+	c, err = defaults.GetBrokerClass("some-namespace-three")
 	if err != nil {
 		t.Error("GetBrokerClass Failed =", err)
 	}

diff --git a/pkg/apis/config/testdata/config-br-defaults.yaml b/pkg/apis/config/testdata/config-br-defaults.yaml
@@ -82,6 +82,10 @@ data:
 
       namespaceDefaults:
         some-namespace:
+          brokerClass: KafkaBroker
+        some-namespace-two:
+          brokerClass: KafkaBroker
+        some-namespace-three:
           brokerClass: someotherbrokerclass
           apiVersion: v1
           kind: ConfigMap
@@ -96,9 +100,4 @@ data:
                 name: someother-handle-error
                 namespace: someothernamespace
             backoffPolicy: linear
-            backoffDelay: 5s
-        some-namespace-two:
-          brokerClass: KafkaBroker
-        some-namespace-three:
-          brokerClass: KafkaBroker
-          
+            backoffDelay: 5s