Remove the hack around fake client list bugs.

[vaikas]

Expected Behavior

That we could just use the dynamic client as is.

Actual Behavior

We have some workarounds in the code like this:
https://github.com/knative/eventing/blob/master/pkg/controller/eventing/subscription/reconcile.go#L302
'''
// TODO this is here because the fake client needs it. Remove this when it's no longer
// needed.
Raw: &metav1.ListOptions{
TypeMeta: metav1.TypeMeta{
APIVersion: v1alpha1.SchemeGroupVersion.String(),
Kind: "Subscription",
},
'''

Additional Info

Looks to have been fixed upstream here:
https://github.com/kubernetes/kubernetes/pull/66078/files

And is part of client-go release 9.

[grantr]

This is actually a workaround required by the controller-runtime fake client. A fix for it was included in kubernetes-sigs/controller-runtime#106 but that was reverted later due to separate concerns. I need to find time to extract the fix into a separate PR, which will probably also fix kubernetes-sigs/controller-runtime#137 (mentioned at #595 (comment)).

[vaikas]

ah, ok. cool.

[mikehelmick]

/kind wont-fix
this is obsolete

/close

[knative-prow-robot]

@mikehelmick: Closing this issue.

In response to this:

/label wont-fix
this is obsolete

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.