Increase code coverage to 70%

[vaikas]

Expected Behavior

Stated goal for the V0.2 release is >70% test coverage.

Actual Behavior

Some packages do not meet this goal.
I used this to create the list:
https://testgrid.knative.dev/knative-eventing#coverage&sort-by-failures=

This is a list of those packages. We are using the checklist here to keep track of which ones are being worked on. So, if you take one, check the box and comment on who's taking it so we don't duplicate the work.

• github.com/knative/eventing/pkg/apis/eventing/v1alpha1/register.go
• github.com/knative/eventing/pkg/buses/message_receiver.go
• github.com/knative/eventing/pkg/controller/eventing/inmemory/channel/controller.go
• github.com/knative/eventing/pkg/controller/eventing/inmemory/controller/main.go
• github.com/knative/eventing/pkg/controller/eventing/subscription/provider.go
• github.com/knative/eventing/pkg/controller/eventing/subscription/reconcile.go
• github.com/knative/eventing/pkg/controller/names.go
• github.com/knative/eventing/pkg/controller/owner_references.go
• github.com/knative/eventing/pkg/controller/testing/mock_client.go
• github.com/knative/eventing/pkg/controller/testing/table.go
• github.com/knative/eventing/pkg/sidecar/configmap/filesystem/filesystem_watcher.go
• github.com/knative/eventing/pkg/apis/eventing/v1alpha1/subscribable_channelable_validation.go
• github.com/knative/eventing/pkg/controller/eventing/inmemory/clusterchannelprovisioner/controller.go
• github.com/knative/eventing/cmd/controller/controller-runtime-main.go
• github.com/knative/eventing/cmd/controller/main.go
• github.com/knative/eventing/cmd/fanoutsidecar/main.go
• github.com/knative/eventing/cmd/sendevent/main.go
• github.com/knative/eventing/cmd/webhook/main.go
• github.com/knative/eventing/pkg/apis/duck/v1alpha1/subscribable_types.go

[grantr]

#592 fixes a few.

[vaikas]

should /pkg/controller/testing/* be included in the coverage?

[vaikas]

I'll takle pkg/controller/eventing/subscription/reconcile.go

[srvaroa]

Just posted #597 for github.com/knative/eventing/pkg/apis/eventing/v1alpha1/subscribable_channelable_validation.go

[srvaroa]

@vaikas-google I suspect I misused the Fixes label in #597 and prow closed this as a side effect, it should be reopened I guess?

[Harwayne]

For what it's worth, as a non-editor on the repo, I can't check any of the boxes.

[grantr]

Good to know @Harwayne. That probably kills collaborative use of checkboxes since ultimately we want very few users having write access to the repo.

[mikehelmick]

/assign @akashrv

[n3wscott]

the project is now overall at 81% with a few low spots, we can open issues to track those individually.
/close

[knative-prow-robot]

@n3wscott: Closing this issue.

In response to this:

the project is now overall at 81% with a few low spots, we can open issues to track those individually.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.