Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance test channel headers 2 #1813

Merged
merged 15 commits into from
Sep 6, 2019
Merged

Conformance test channel headers 2 #1813

merged 15 commits into from
Sep 6, 2019

Conversation

aslom
Copy link
Member

@aslom aslom commented Sep 5, 2019

Copied from PR #1794 to avoid git googlebot/cla issues

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 5, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2019
@knative-prow-robot
Copy link
Contributor

Hi @aslom. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test-and-release Test infrastructure, tests or release labels Sep 5, 2019
@aslom aslom changed the title Copied from PR #1794 to avoid git googlebot/cla issues Conformance test channel headers Sep 5, 2019
@aslom aslom changed the title Conformance test channel headers Conformance test channel headers 2 Sep 5, 2019
@aslom aslom mentioned this pull request Sep 5, 2019
Closed
@aslom
Copy link
Member Author

aslom commented Sep 5, 2019

/assign @Fredy-Z
/assign @Harwayne

@aslom aslom mentioned this pull request Sep 5, 2019
Closed
@aslom
Copy link
Member Author

aslom commented Sep 5, 2019

/assign @Harwayne

Harwayne
Harwayne reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a few questions.

test/test_images/eventdetails/main.go Outdated Show resolved Hide resolved
test/test_images/sendevents/main.go Outdated Show resolved Hide resolved
test/test_images/sendeventswithtracing/main.go Outdated Show resolved Hide resolved
test/test_images/sendeventswithtracing/main.go Outdated Show resolved Hide resolved
test/test_images/sendeventswithtracing/README.md Outdated Show resolved Hide resolved
test/conformance/alias.go Outdated Show resolved Hide resolved
test/conformance/README.md Show resolved Hide resolved
test/conformance/header_test.go Outdated Show resolved Hide resolved
test/conformance/helpers/channel_header_single_event_helper.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 5, 2019
@aslom @mattmoor-sockpuppet
Update test/test_images/eventdetails/README.md
bd2673d 
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
@chizhg
Copy link
Member

chizhg commented Sep 5, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2019
@chizhg
Copy link
Member

chizhg commented Sep 5, 2019

Could you please add ./test/conformance at

eventing/test/e2e-tests.sh

Line 33 in 42a96f4

go_test_e2e -timeout=20m -parallel=12 ./test/e2e || fail_test
to make it running together with e2e tests?

@aslom
Copy link
Member Author

aslom commented Sep 6, 2019

@Fredy-Z added ./test/conformance to eventing/test/e2e-tests.sh but it seems I can not run as I do not have gcloud?

(base) aslom@m test (conformance-test-channel-headers-2) $ ./e2e-tests.sh
error: set $PROJECT_ID or use --gcp-project to select the GCP project where the tests are run

@matzew
Copy link
Member

matzew commented Sep 6, 2019

/ok-to-test

@chizhg
Copy link
Member

chizhg commented Sep 6, 2019

@Fredy-Z added ./test/conformance to eventing/test/e2e-tests.sh but it seems I can not run as I do not have gcloud?

(base) aslom@m test (conformance-test-channel-headers-2) $ ./e2e-tests.sh
error: set $PROJECT_ID or use --gcp-project to select the GCP project where the tests are run

You should be able to run with ./e2e-tests.sh --run-tests, which will run the e2e tests on your current cluster. See doc here - https://github.com/knative/eventing/tree/master/test.
But you don't have to since the presubmit job will run all the tests for you, that's what I usually do :-)

@chizhg
Copy link
Member

chizhg commented Sep 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@aslom
Copy link
Member Author

aslom commented Sep 6, 2019

@Fredy-Z ./e2e-tests.sh --run-tests fails for me - maybe I am missing some setup steps?
Opened issue to track it and document it #1833

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@aslom
Copy link
Member Author

aslom commented Sep 6, 2019

@Harwayne let me know about header.Get semantics - it can be changed later if necessary I think

Harwayne
Harwayne reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aslom, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@Harwayne
Copy link
Contributor

Harwayne commented Sep 6, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@knative-prow-robot knative-prow-robot merged commit 0982459 into knative:master Sep 6, 2019
@aslom aslom mentioned this pull request Sep 9, 2019
Closed
matzew pushed a commit to matzew/eventing that referenced this pull request Aug 24, 2022
@Kaustubh-pande
bump go restful v3.8 for CVE-2022-1996 (knative#1813)
887e4fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Harwayne left review comments

@chizhg chizhg chizhg left review comments

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@coryrc coryrc Awaiting requested review from coryrc

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@Harwayne Harwayne

@chizhg chizhg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aslom @knative-prow-robot @chizhg @matzew @Harwayne @mattmoor-sockpuppet @googlebot