Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when secret copy fails, emit warning event #2319

Merged
merged 2 commits into from
Dec 13, 2019
Merged

when secret copy fails, emit warning event #2319

merged 2 commits into from
Dec 13, 2019

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Dec 13, 2019 •
edited
Loading

Proposed Changes

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 13, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2019
@vaikas
Copy link
Contributor Author

vaikas commented Dec 13, 2019

@beemarie FYI

@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
mikehelmick
mikehelmick approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@mikehelmick mikehelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/namespace/namespace.go 75.0% 76.1% 1.1

@vaikas
Copy link
Contributor Author

vaikas commented Dec 13, 2019

/test pull-knative-eventing-unit-tests

@knative-prow-robot knative-prow-robot merged commit 1b27995 into knative:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehelmick mikehelmick mikehelmick approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@matzew matzew Awaiting requested review from matzew

Assignees

@mikehelmick mikehelmick

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vaikas @n3wscott @knative-prow-robot @knative-metrics-robot @mikehelmick @googlebot